Skip to content

fix app crash on loading comment section with no internet #13448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theimpulson merged 2 commits into from
Apr 24, 2026
+38 −4
Merged

fix app crash on loading comment section with no internet #13448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78f9fba
fix app crash on loading comment with no internet
Idadelveloper Apr 23, 2026
188ba0a
refactor if statements to when block
Idadelveloper Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions app/src/main/java/org/schabi/newpipe/paging/CommentsSource.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,14 @@ class CommentsSource(private val commentInfo: CommentInfo) : PagingSource<Page,
if (params.key == null) {
return LoadResult.Page(commentInfo.comments, null, commentInfo.nextPage)
} else {
val info = withContext(Dispatchers.IO) {
CommentsInfo.getMoreItems(service, commentInfo.url, params.key)
return try {
val info = withContext(Dispatchers.IO) {
CommentsInfo.getMoreItems(service, commentInfo.url, params.key)
}
LoadResult.Page(info.items, null, info.nextPage)
} catch (exception: Exception) {
LoadResult.Error(exception)
}

return LoadResult.Page(info.items, null, info.nextPage)
}
}

Expand Down
31 changes: 31 additions & 0 deletions app/src/main/java/org/schabi/newpipe/ui/components/video/comment/CommentSection.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,37 @@ private fun CommentSection(
items(comments.itemCount) {
Comment(comment = comments[it]!!) {}
}

// handle append (next page) errors
when (comments.loadState.append) {
is LoadState.Error -> {
item {
ErrorPanel(
errorInfo = ErrorInfo(
throwable = (comments.loadState.append as LoadState.Error).error,
userAction = UserAction.REQUESTED_COMMENTS,
request = "comments"
),
onRetry = { comments.retry() },
modifier = Modifier.fillMaxWidth()
)
}
}

// show loading indicator while appending
is LoadState.Loading -> {
item {
LoadingIndicator(
modifier = Modifier.padding(
top = 8.dp,
bottom = 8.dp
)
)
}
}

else -> {}
}
}
}
}
Expand Down
Loading