Skip to content

fix app crash on loading comment section with no internet#13448

Merged
theimpulson merged 2 commits intorefactorfrom
comment-crash
Apr 24, 2026
Merged

fix app crash on loading comment section with no internet#13448
theimpulson merged 2 commits intorefactorfrom
comment-crash

Conversation

@Idadelveloper
Copy link
Copy Markdown

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Fix crash when scrolling the comment section without internet by catching exceptions in CommentsSource.load() and returning LoadResult.Error, and handle the paging append error state in CommentSection to show an error panel with a retry button.

Before/After Screenshots/Screen Record

  • Before:
  • After:

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Apr 23, 2026
@theimpulson theimpulson merged commit a44e65e into refactor Apr 24, 2026
5 checks passed
@theimpulson theimpulson deleted the comment-crash branch April 24, 2026 09:48
@ShareASmile ShareASmile added bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios rewrite Issues and PRs related to rewrite labels Apr 24, 2026
@github-project-automation github-project-automation Bot moved this to Done in Rewrite Apr 24, 2026
@ShareASmile ShareASmile moved this from Done to In Progress in Rewrite Apr 24, 2026
@ShareASmile ShareASmile moved this from In Progress to Done in Rewrite Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios rewrite Issues and PRs related to rewrite size/small PRs with less than 50 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants