Skip to content

gen new mineflayer version#514

Open
zardoy wants to merge 1 commit intonextfrom
gen-mineflayer
Open

gen new mineflayer version#514
zardoy wants to merge 1 commit intonextfrom
gen-mineflayer

Conversation

@zardoy
Copy link
Copy Markdown
Owner

@zardoy zardoy commented Mar 12, 2026

Note

Medium Risk
Swaps the project-wide mineflayer implementation to a different GitHub fork, which can subtly change bot/client behavior and protocol handling. Lockfile changes also alter transitive dependency resolutions (e.g., https-proxy-agent/debug).

Overview
Updates the mineflayer dependency source from zardoy/mineflayer#gen-the-master to GenerelSchwerz/mineflayer, including the pnpm.overrides pin so the new fork is enforced across dependents.

Regenerates pnpm-lock.yaml to reflect the new mineflayer tarball/version and adjusted transitive resolutions (notably https-proxy-agent now pulling a newer debug).

Written by Cursor Bugbot for commit 992b870. This will update automatically on new commits. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated the mineflayer package source to use an alternative repository.

@zardoy
Copy link
Copy Markdown
Owner Author

zardoy commented Mar 12, 2026

/deploy

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 12, 2026

📝 Walkthrough

Walkthrough

Updated the mineflayer package dependency source from one GitHub repository to another, modifying both the direct dependency reference and the pnpm override configuration to point to a new maintainer's fork.

Changes

Cohort / File(s) Summary
Dependency Update
package.json
Changed mineflayer package source from github:zardoy/mineflayer#gen-the-master to github:GenerelSchwerz/mineflayer in both dependencies and pnpm.overrides fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A new branch to mine, a different fork to follow,
From zardoy's path to GenerelSchwerz's hollow,
The pickaxe swings with a GitHub address change,
Dependencies dance in this lovely new range,
Two lines of code, two dependencies blessed,
Our mineflayer now sourced for the quest! ⛏️

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title refers to updating the mineflayer package source but uses vague phrasing ('gen new version') that doesn't clearly convey the actual change (switching from one fork to another). Consider a more specific title like 'Update mineflayer dependency to GenerelSchwerz fork' to clearly communicate the actual source repository change.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gen-mineflayer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Deployed to Vercel Preview: https://prismarine-a7q88r2tz-zaro.vercel.app
Playground
Storybook

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Line 159: package.json currently references the forked dependency as
"mineflayer": "github:GenerelSchwerz/mineflayer" which is unpinned; update both
occurrences of that dependency (the two "mineflayer" entries) to pin the tested
commit by appending the commit SHA (e.g. change to
"github:GenerelSchwerz/mineflayer#c4bd50c0785ef2fabdc927a269f9647250d63554") so
installs remain immutable when the lockfile is refreshed or updated.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dbf0a622-3615-4fda-a1e1-c8fab110e168

📥 Commits

Reviewing files that changed from the base of the PR and between 3877d83 and 992b870.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Comment thread package.json
"mc-assets": "^0.2.72",
"minecraft-inventory-gui": "github:zardoy/minecraft-inventory-gui#next",
"mineflayer": "github:zardoy/mineflayer#gen-the-master",
"mineflayer": "github:GenerelSchwerz/mineflayer",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

python - <<'PY'
import json, pathlib
pkg = json.loads(pathlib.Path("package.json").read_text())
print("devDependencies.mineflayer =", pkg["devDependencies"]["mineflayer"])
print("pnpm.overrides.mineflayer =", pkg["pnpm"]["overrides"]["mineflayer"])
PY

lockfile="$(fd '^pnpm-lock\.yaml$' . | head -n1 || true)"
if [ -z "$lockfile" ]; then
  echo
  echo "pnpm-lock.yaml not found"
  exit 0
fi

echo
echo "Resolved mineflayer entries in $lockfile:"
rg -n -C2 'GenerelSchwerz/mineflayer|mineflayer@github:' "$lockfile"

Repository: zardoy/minecraft-web-client

Length of output: 3426


Pin the new Mineflayer fork to an immutable ref in package.json.

While pnpm-lock.yaml currently resolves github:GenerelSchwerz/mineflayer to a specific commit (c4bd50c0785ef2fabdc927a269f9647250d63554), the unpinned entries in package.json create risk when the lockfile is refreshed, deleted, or when pnpm update is run—all of which would then follow the fork's default branch. Given the high coupling throughout the app, please pin both entries with the tested commit hash or tag.

Suggested change
-    "mineflayer": "github:GenerelSchwerz/mineflayer",
+    "mineflayer": "github:GenerelSchwerz/mineflayer#c4bd50c0785ef2fabdc927a269f9647250d63554",

(Also apply line 200 with the same commit hash)

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"mineflayer": "github:GenerelSchwerz/mineflayer",
"mineflayer": "github:GenerelSchwerz/mineflayer#c4bd50c0785ef2fabdc927a269f9647250d63554",
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@package.json` at line 159, package.json currently references the forked
dependency as "mineflayer": "github:GenerelSchwerz/mineflayer" which is
unpinned; update both occurrences of that dependency (the two "mineflayer"
entries) to pin the tested commit by appending the commit SHA (e.g. change to
"github:GenerelSchwerz/mineflayer#c4bd50c0785ef2fabdc927a269f9647250d63554") so
installs remain immutable when the lockfile is refreshed or updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant