refactor(controller): use kubernetes informers provided by client-go#3080
Open
zak905 wants to merge 2 commits intozalando:masterfrom
Open
refactor(controller): use kubernetes informers provided by client-go#3080zak905 wants to merge 2 commits intozalando:masterfrom
zak905 wants to merge 2 commits intozalando:masterfrom
Conversation
zak905
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
mikkeloscar and
sdudoladov
as code owners
zak905
force-pushed
the
refactor_use_pre_generated_informers
branch
2 times, most recently
from
0d448a5 to
d5220d9
Compare
zak905
force-pushed
the
refactor_use_pre_generated_informers
branch
from
eab6a9a to
5a4837f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a refactoring: the client-go informers package provides pre-generated informers for all the kubernetes built-in kinds. No need to bootstrap a SharedIndexInformer for
PodandNode