refactor parts of DoServerKeyExchange()

[effbiae]

Description

#9165 aligned parts of DoServerKeyExchange(). now, the common parts of DoServerKeyExchange() are pulled out to separate functions: GetPSKServerHint() and GetEcDiffieHellmanKea(). maybe there are better names for these.

Testing

./configure && make check && ./configure --enable-all && make check

Checklist

• added tests
• updated/added doxygen
• updated appropriate READMEs
• Updated manual and documentation

[wolfSSL-Bot]

Can one of the admins verify this patch?

[dgarske]

Okay to test. Contributor agreement on file

[dgarske]

Jenkins retest this please: Several tests failed with "RequestAbortedException" and it does not appear related to these chagnes.

[dgarske]

Hi @effbiae can you please rebase and force push to clear those Ubuntu --enable-coding=no issues? This refactor looks good.

[SparkiDev]

Great refactor!
Cleans the code up nicely!

[dgarske]

Looks like hard tabs vs 4 spaces in a few places.

./src/internal.c:32271:»return ECC_CURVE_ERROR;
./src/internal.c:32280:»return BUFFER_ERROR;
./src/internal.c:32284:»if (ssl->peerX25519Key == NULL) {
./src/internal.c:32285:»    ret = AllocKey(ssl, DYNAMIC_TYPE_CURVE25519,
./src/internal.c:32286:»                   (void **)&ssl->peerX25519Key);
./src/internal.c:32287:»    if (ret != 0) {
./src/internal.c:32288:»»return ret;
./src/internal.c:32289:»    }
[...and more...]

[effbiae]

oops -- should have been indent -linux -nut -i4

[effbiae]

what happened in PRB-master-job?

[SparkiDev]

retest this please

Too old to see what went wrong.
Probably an issue with infrastructure.

Issue raised was fixed.