Skip to content

curl: support --enable-curl=tiny option.#9174

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
philljj:tiny_curl
Sep 11, 2025
Merged

curl: support --enable-curl=tiny option.#9174
dgarske merged 1 commit intowolfSSL:masterfrom
philljj:tiny_curl

Conversation

@philljj
Copy link
Copy Markdown
Contributor

@philljj philljj commented Sep 9, 2025

Description

A tiny change that allows wolfSSL x509 small + HAVE_CURL to support tiny-curl-8.4.0 default build.

Building

Build wolfssl with:

./configure --enable-curl=tiny && make && sudo make install

Build tiny-curl-8.4.0 with:

./configure --with-wolfssl && make

Testing

Result of tiny-curl make test with wolfssl --enable-curl=tiny:

test 3201...OK (1291 out of 1291, remaining: 00:00, took 1.071s, duration: 37:26)
TESTDONE: 1646 tests were considered during 2247 seconds.
TESTDONE: 1189 tests out of 1193 reported OK: 99%

TESTFAIL: These test cases failed: 1119 1165 1167 1474

The same with normal wolfssl --enable-curl on master:

test 3201...OK (1407 out of 1407, remaining: 00:00, took 1.074s, duration: 38:01)
TESTDONE: 1646 tests were considered during 2282 seconds.
TESTDONE: 1303 tests out of 1307 reported OK: 99%

TESTFAIL: These test cases failed: 1119 1165 1167 1474 

Notes

  • --enable-curl=tiny will not build normal libcurl, because SSL_CTX_*_cert_store symbols are missing.
  • --enable-opensslextra can build both normal libcurl, and tiny-curl.

@philljj philljj self-assigned this Sep 9, 2025
@philljj philljj marked this pull request as draft September 9, 2025 02:52
@philljj
Copy link
Copy Markdown
Contributor Author

philljj commented Sep 9, 2025

Retest this please, AgentOfflineException exception:.

@dgarske dgarske requested a review from bagder September 9, 2025 16:52
@bagder
Copy link
Copy Markdown

bagder commented Sep 9, 2025

I presume this is for SSL_CTX_set1_curves_list ?

In later versions of curl we have changed that to use the more appropriate wolfSSL_CTX_set1_curves_list. Would that make any difference for the build?

@philljj
Copy link
Copy Markdown
Contributor Author

philljj commented Sep 10, 2025

I presume this is for SSL_CTX_set1_curves_list ?

In later versions of curl we have changed that to use the more appropriate wolfSSL_CTX_set1_curves_list. Would that make any difference for the build?

Correct!

The naming is fine, because we remap the openssl to wolfssl names in wolfssl/openssl/ssl.h anyways.

The deal is, on wolfssl master:

  • --enable-opensslextra=x509small: SSL_CTX_set1_curves_list is missing, tiny-curl won't build.
  • --enable-opensslextra=x509small + HAVE_CURL: has the missing symbol, but wolfssl won't build.

On this PR branch:

  • --enable-opensslextra=x509small + HAVE_CURL: wolfssl and tiny-curl build.

This PR also adds --enable-curl=tiny that is equivalent to --enable-opensslextra=x509small + HAVE_CURL.

@philljj philljj marked this pull request as ready for review September 10, 2025 14:53
@dgarske dgarske merged commit f0b35d1 into wolfSSL:master Sep 11, 2025
398 of 401 checks passed
@philljj philljj deleted the tiny_curl branch September 12, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants