WOLFSSL_SS_* small stack macro compress#9130
Closed
effbiae wants to merge 1 commit intowolfSSL:masterfrom
Closed
Conversation
|
Can one of the admins verify this patch? |
Contributor
Author
|
i don't think these failures are related to the PR:
|
dgarske
requested changes
Aug 29, 2025
Member
dgarske
left a comment
There was a problem hiding this comment.
We actually have a pattern for this all ready. See wolfssl/wolfcrypt/types.h WC_DECLARE_VAR, WC_ALLOC_VAR, WC_FREE_VAR and WC_DECLARE_ARRAY, WC_ALLOC_ARRAY, WC_FREE_ARRAY
You are welcome to refactor these to use the existing helpers. However there are many places we do this small stack pattern, so I am also fine if you want to close this PR.
Contributor
Author
|
superseded by #9153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are many lines of small stack conditional compiles (
#ifdef WOLFSSL_SMALL_STACK) that can be compressed to fewer lines using the macros introduced in this PR.I've compressed
src/ssl_load.cby hand resulting in a net 100 line deletion in the code base. I hope to automate some of the rest of the work which I can do in stages, if that suits.I considered calling the macros
WOLFSSL_SMALL_STACK_*, but the names became quite long.Testing