Fix SAKKE OOB write and correctness gap in sakke_hash_to_range#10442
Open
JeremiahM37 wants to merge 5 commits intowolfSSL:masterfrom
Open
Fix SAKKE OOB write and correctness gap in sakke_hash_to_range#10442JeremiahM37 wants to merge 5 commits intowolfSSL:masterfrom
JeremiahM37 wants to merge 5 commits intowolfSSL:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sakke_xor_in_vheap buffer overflow whenssvSz > hashSzand(ssvSz % hashSz) != 0.sakke_xor_in_vcorrectness gap — output for some(ssvSz, hashSz)combinations does not match RFC 6508 §5.1.wc_MakeSakkeEncapsulatedSSV/wc_DeriveSakkeSSVdid not validatessvSz.Fixes Audit 7 of zd21783
Testing
sakke_xor_in_v_oob_testandsakke_mask_correctness_testintests/unit.c.wolfcrypt/test/testwolfcryptSAKKE KAT still passes.