Skip to content

fix NO_VERIFY_OID build in GetOID#10440

Open
JeremiahM37 wants to merge 2 commits intowolfSSL:masterfrom
JeremiahM37:gh10423
Open

fix NO_VERIFY_OID build in GetOID#10440
JeremiahM37 wants to merge 2 commits intowolfSSL:masterfrom
JeremiahM37:gh10423

Conversation

@JeremiahM37
Copy link
Copy Markdown
Contributor

Description

Move actualOid and actualOidSz declarations out of the #ifndef NO_VERIFY_OID block in GetOID() and drop the assignment guard. They're used unconditionally by wc_oid_sum() (added in 1123516), so gating the declarations on NO_VERIFY_OID broke compilation.
NO_VERIFY_OID + WOLFSSL_FPKI was broken for the same reason.

Fixes #10423

Credit

Thanks to @cpsource for the proposed patch

Testing

Pre-patch with -DNO_VERIFY_OID: reproduces reporter's compile error.
Post-patch with -DNO_VERIFY_OID, -DNO_VERIFY_OID -DWOLFSSL_FPKI, and default: all build clean. make check passes.

@JeremiahM37 JeremiahM37 self-assigned this May 8, 2026
Copy link
Copy Markdown
Member

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an os-check for the NO_VERIFY_OID in the build matrix. Our CI should have caught this.

@JeremiahM37
Copy link
Copy Markdown
Contributor Author

Please add an os-check for the NO_VERIFY_OID in the build matrix. Our CI should have caught this.

Done

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

MemBrowse Memory Report

No memory changes detected for:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: enabling NO_VERIFY_OID can break compilation

2 participants