Skip to content

ML-KEM: fix AVX2 assembly #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SparkiDev wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −2
Open

ML-KEM: fix AVX2 assembly #10430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions wolfcrypt/src/wc_mlkem.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ sword16 wc_mlkem_opt_blocker(void) {

/******************************************************************************/

#ifndef WOLFSSL_MLKEM_NO_MAKE_KEY
/* Get the k value (number of polynomials in a vector) from the key type.
*
* @param [in] key ML-KEM key object.
Expand Down Expand Up @@ -225,6 +226,7 @@ static int mlkemkey_get_k(const MlKemKey* key)
return 0;
}
}
#endif

#ifdef WOLFSSL_MLKEM_DYNAMIC_KEYS
/* Allocate (or reallocate) the private key buffer, right-sized for k.
Expand Down
7 changes: 5 additions & 2 deletions wolfcrypt/src/wc_mlkem_asm.S
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14458,8 +14458,8 @@ L_mlkem_decompress_5_avx2_shuf:
.p2align 4
#endif /* __APPLE__ */
L_mlkem_decompress_5_avx2_mask:
.short 0x001f,0x03e0,0x007c,0x0f80,0x01f0,0x003e,0x07c0,0x00fb
.short 0x001f,0x03e0,0x007c,0x0f80,0x01f0,0x003e,0x07c0,0x00fb
.short 0x001f,0x03e0,0x007c,0x0f80,0x01f0,0x003e,0x07c0,0x00f8
.short 0x001f,0x03e0,0x007c,0x0f80,0x01f0,0x003e,0x07c0,0x00f8
#ifndef __APPLE__
.data
#else
Expand Down Expand Up @@ -15534,6 +15534,9 @@ _mlkem_cmp_avx2:
vpxor 1504(%rsi), %ymm1, %ymm1
vpor %ymm0, %ymm2, %ymm2
vpor %ymm1, %ymm3, %ymm3
vmovdqu 1536(%rdi), %ymm0
vpxor 1536(%rsi), %ymm0, %ymm0
vpor %ymm0, %ymm2, %ymm2
L_mlkem_cmp_avx2_done:
vpor %ymm3, %ymm2, %ymm2
vptest %ymm2, %ymm2
Expand Down
Loading