Remove liboqs for ML-KEM and ML-DSA, update for Falcon#10293
Open
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Open
Remove liboqs for ML-KEM and ML-DSA, update for Falcon#10293Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Frauschi wants to merge 1 commit intowolfSSL:masterfrom
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove liboqs integrations for ML-KEM and ML-DSA, building only on our own implementations. The liboqs integration for these two algorithms has been formally deprecated for a long time. Integration for SPHINCS+ via liboqs will be independently removed in #10261.
In this process, the two configuration macros
WOLFSSL_HAVE_MLKEMandHAVE_DILITHIUMare now the sole option required to enable the desired algorithm. The additional optionsWOLFSSL_WC_MLKEMandWOLFSSL_WC_DILITHIUMhave been removed, as they are redundant now.The current Falcon (future FN-DSA) integration is updated to work with the latest liboqs release (version ) and both OIDs as well as code points are updated to the latest oqs-provider (version ). Furthermore, the private key DER encoding is updated to be aligned with oqs-provider. Configuration-wise, a new
--enable-falconis introduced which has to go together with the existing--with-liboqs(which itself requires--enable-experimental) to enable this functionality. Same goes for CMake.This will need so updates when #9843 and #10261 land, but put it up now to get CI tests working.