Skip to content

Don't force enable MD5 with --enable-jni#10011

Merged
cconlon merged 1 commit intowolfSSL:masterfrom
mattia-moffa:20260319-jni-no-md5
Mar 19, 2026
Merged

Don't force enable MD5 with --enable-jni#10011
cconlon merged 1 commit intowolfSSL:masterfrom
mattia-moffa:20260319-jni-no-md5

Conversation

@mattia-moffa
Copy link
Copy Markdown
Contributor

@mattia-moffa mattia-moffa commented Mar 19, 2026

Description

Currently, when compiling with --enable-jni, MD5 gets enabled when enabling OPENSSLEXTRA, but this complicates FIPS builds where you might want to disable MD5 to keep non-certified algorithms out.

Related to wolfSSL/wolfssl-containers#10

Testing

./autogen.sh
./configure --enable-jni --disable-md5
make
make check

@mattia-moffa mattia-moffa self-assigned this Mar 19, 2026
@mattia-moffa mattia-moffa added the Not For This Release Not for release 5.9.1 label Mar 19, 2026
Copilot AI review requested due to automatic review settings March 19, 2026 01:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Stops the --enable-jni path from implicitly enabling MD5 when OPENSSLEXTRA is turned on, to better support FIPS-oriented builds that intentionally disable MD5.

Changes:

  • Prevent MD5 from being force-enabled as a side effect of enabling OPENSSLEXTRA under --enable-jni.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread configure.ac Outdated
@mattia-moffa
Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins FIPS-windows-test-ACVP

@dgarske dgarske requested a review from cconlon March 19, 2026 19:30
@cconlon cconlon merged commit 8b388ba into wolfSSL:master Mar 19, 2026
598 of 599 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not For This Release Not for release 5.9.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants