fix(hypervisors): prevent double --initramfs flag in Cloud Hypervisor command#680
Open
mdryaan wants to merge 1 commit into
Open
fix(hypervisors): prevent double --initramfs flag in Cloud Hypervisor command#680mdryaan wants to merge 1 commit into
mdryaan wants to merge 1 commit into
Conversation
… command Signed-off-by: mdryaan <alikhurshid842001@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Author
|
Hey @cmainas , Could you please have a look at this PR whenever you have time? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BuildExecCmdincloud_hypervisor.goappended--initramfsunconditionally for bothargs.InitrdPathandextraMonArgs.ExtraInitrd. When both were set, the Cloud Hypervisor command line contained two--initramfsflags and Cloud Hypervisor rejected it. Apply the same priority-fallback logic already used by the Firecracker implementation: resolve toargs.InitrdPathif set, otherwise fall back toextraMonArgs.ExtraInitrd, and append at most one--initramfs.Related issues
How was this tested?
Added
TestCloudHypervisorSingleInitrdtopkg/unikontainers/hypervisors/cloud_hypervisor_test.go. The test callsBuildExecCmdwith bothargs.InitrdPathand a mock unikernel returning a non-emptyExtraInitrd, then counts--initramfsoccurrences in the result.Before fix:
After fix:
Run with:
go test ./pkg/unikontainers/hypervisors/ -v -run TestCloudHypervisorSingleInitrd
golangci-lint runpasses with 0 issues.makebuilds successfully.LLM usage
N/A
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).