test(unikernels): add unit tests for Mewz#640
Open
r0hansaxena wants to merge 1 commit into
Open
Conversation
Signed-off-by: r0hansaxena <rohansxn8772@gmail.com>
✅ Deploy Preview for urunc canceled.
|
cmainas
reviewed
May 14, 2026
| assert.Empty(t, got.ExtraInitrd) | ||
|
|
||
| assert.Equal(t, types.MonitorCliArgs{}, (&Mewz{Monitor: "spt"}).MonitorCli()) | ||
| } |
Contributor
There was a problem hiding this comment.
Why do not we add more checks for the monitors as the previous unit test?
| assert.NoError(t, err) | ||
| assert.Equal(t, 24, m.Net.Mask) | ||
|
|
||
| out, _ := m.CommandString() |
Contributor
There was a problem hiding this comment.
No reason to callCommandString, we can accessing the struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds unit tests for the Mewz unikernel backend, covering CommandString, MonitorNetCli, MonitorBlockCli, MonitorCli, SupportsBlock, SupportsFS and Init. Tests verify the ip/gateway cmdline format, the qemu-only virtio-net device line, the no-block/no-fs guarantees, the qemu-specific monitor args (-no-reboot and isa-debug-exit) and Init's mask handling including the default /24 fallback when no mask is provided.
Related issues
How was this tested?
All 7 unit tests pass locally. Full package tests pass. Linter passes (make lint, 0 issues).
LLM usage
LLM assisted with locating coverage gaps only. All code was written manually and tested locally.
Checklist
make lint).make test_ctr,make test_nerdctl,make test_docker,make test_crictl).