Skip to content

libsql: Improve sync protocol probe tracing #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
penberg merged 1 commit into from
Mar 20, 2025
Merged

libsql: Improve sync protocol probe tracing #1994

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions libsql/src/database/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,7 @@ cfg_replication! {
use super::SyncProtocol;
match sync_protocol {
p @ (SyncProtocol::Auto | SyncProtocol::V2) => {
tracing::trace!("Probing for sync protocol version for {}", url);
let client = hyper::client::Client::builder()
.build::<_, hyper::Body>(connector.clone());

Expand All @@ -381,6 +382,8 @@ cfg_replication! {
.await
.map_err(|err| crate::Error::Sync(err.into()))?;

tracing::trace!("Probe for sync protocol version for {} returned status {}", url, res.status());

if res.status() == http::StatusCode::UNAUTHORIZED {
return Err(crate::Error::Sync("Unauthorized".into()));
}
Expand All @@ -397,15 +400,18 @@ cfg_replication! {
}

if res.status().is_success() {
tracing::trace!("Using sync protocol v2 for {}", url);
return Builder::new_synced_database(path, url, auth_token)
.remote_writes(true)
.read_your_writes(read_your_writes)
.build()
.await;
}

tracing::trace!("Using sync protocol v1 for {} based on probe results", url);
}
SyncProtocol::V1 => {
tracing::trace!("Using sync protocol v1 for {}", url);
}
SyncProtocol::V1 => {}
}
}

Expand Down
Loading