define and enforce max threshold for agentd boot sequence in CI #552
Open
eric-14 wants to merge 3 commits intosuperradcompany:mainfrom
Open
define and enforce max threshold for agentd boot sequence in CI #552eric-14 wants to merge 3 commits intosuperradcompany:mainfrom
eric-14 wants to merge 3 commits intosuperradcompany:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR solve.
The PR updates github workflows(check.yml) to include verification of boot timings defined in the scripts/ci/boot-timing-thresholds.json file. The python script in scripts/ci directory consumes the JSON file and outputs ms and ns of the boot timings.
Further additions.
To test boot timings of different sandboxes an example sandbox has been created in the example directory. Modification can be done to the file main.rs in the boot-timing-ci directory to test boot times of different images.