sqlite3: fix internal return type violation in escapeString()#22026
Open
ndossche wants to merge 1 commit into
Open
sqlite3: fix internal return type violation in escapeString()#22026ndossche wants to merge 1 commit into
ndossche wants to merge 1 commit into
Conversation
If this call fails due to an internal libsqlite3 error, then the function will return NULL (as that's the default value set by the VM). However, the function is marked with a non-nullable string return type. Therefore this will result in a type violation and a fatal error in debug mode. Either we solve it by making the function nullable or throw. I chose the latter as it is less of a footgun.
Member
|
is correct but not sure it fully qualify as bug fix ? master ? |
Member
Author
Fine by me |
devnexen
approved these changes
May 13, 2026
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
lgtm but I do think it belongs to master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this call fails due to an internal libsqlite3 error, then the function will return NULL (as that's the default value set by the VM). However, the function is marked with a non-nullable string return type. Therefore this will result in a type violation and a fatal error in debug mode.
Either we solve it by making the function nullable or throw. I chose the latter as it is less of a footgun.
Found by a static-dynamic analyser I'm developing.