Skip to content

feat: Dockerfile for reproducible dev/ci environment #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fjfnaranjo wants to merge 1 commit into
base: master
Choose a base branch
from
+30 −0
Open

feat: Dockerfile for reproducible dev/ci environment #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,15 @@ make colors-check

This is run in CI and ensures that generation was correct by re-running it and validating that no changes were made.

### Using the local container image

You can build and use the included container image to run the previous commands.

```sh
docker build -t nvim-web-devicons:latest .
docker run --rm -ti --user "`id -u`:`id -g`" -v "$(pwd):/host" -w /host nvim-web-devicons:latest make
Comment on lines +143 to +144
Copy link
Copy Markdown
Contributor Author

@fjfnaranjo fjfnaranjo Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, someone run this commands locally. I don't have docker to test them.

Copy link
Copy Markdown
Member

@alex-courtis alex-courtis Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, someone run this commands locally. I don't have docker to test them.

I might be starting to understand now. Why is docker not available? Is it an OS dependent restriction we need to be aware of?

I'm a linux user with no access to or expertise with other OSs.

Copy link
Copy Markdown
Contributor Author

@fjfnaranjo fjfnaranjo Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem of availability. Is just me. I prefer Podman and there is no reason to install Docker if you are using Podman. Also, the main way to install Docker in my system (Debian) is using an external APT repository, and that's a new vector for supply chain attacks. So I keep my system as close as possible to a pure Debian distribution as possible.

I'm a very opinionated person, don't give to much thought about it. I just don't have and prefer no to install Docker in my system.

```

## Test

Run `:NvimWebDeviconsHiTest` to view the icons and their highlighting.
Expand Down
21 changes: 21 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
FROM debian:stable-slim
Copy link
Copy Markdown
Contributor Author

@fjfnaranjo fjfnaranjo Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is latest, but not latest-slim. latest seems to be interchangeable with stable in this case (and will update when a new stable is made available).


ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
make gcc curl npm luarocks git \
&& rm -rf /var/lib/apt/lists/*

# Neovim
RUN curl -L 'https://github.com/neovim/neovim/releases/download/stable/nvim-linux-x86_64.tar.gz' \
| tar zx --directory /usr/local --strip-components=1

## luacheck
RUN luarocks install luacheck

## stylua wrapper (npx to avoid cargo deps)
RUN set -eux; \
printf '#!/bin/sh\nnpx --yes @johnnymorganz/stylua-bin "$@"\n' > /usr/local/bin/stylua; \
chmod +x /usr/local/bin/stylua; \
npx --yes @johnnymorganz/stylua-bin --help >/dev/null 2>&1
Comment thread
fjfnaranjo marked this conversation as resolved.
Loading