fix: use truthy check for VITE_LLM_MODELS and VITE_CHAT_MODES env vars#1548
Open
learner-77 wants to merge 1 commit intoneo4j-labs:mainfrom
Open
fix: use truthy check for VITE_LLM_MODELS and VITE_CHAT_MODES env vars#1548learner-77 wants to merge 1 commit intoneo4j-labs:mainfrom
learner-77 wants to merge 1 commit intoneo4j-labs:mainfrom
Conversation
Replace != '' guard with truthy check for llms, prodllms, and chatModes. undefined?.trim() returns undefined, and undefined != '' is true, causing the env var guard to pass with an undefined value — crashing callers that call .split() or .includes() on it. Also fix chatModes mapping: split values like 'graph+vector' are human-readable labels, not internal mode keys. Map through chatModeLables and filter out any mode not present in chatModeReadableLables to prevent ChatModeToggle crash on unknown keys. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace != '' guard with truthy check for llms, prodllms, and chatModes. undefined?.trim() returns undefined, and undefined != '' is true, causing the env var guard to pass with an undefined value — crashing callers that call .split() or .includes() on it.
Also fix chatModes mapping: split values like 'graph+vector' are human-readable labels, not internal mode keys. Map through chatModeLables and filter out any mode not present in chatModeReadableLables to prevent ChatModeToggle crash on unknown keys.