Skip to content

feat: add /health check and modernize public endpoints#552

Open
ayushshukla1807 wants to merge 2 commits intohatnote:masterfrom
ayushshukla1807:feat/health-check-and-modernize-public
Open

feat: add /health check and modernize public endpoints#552
ayushshukla1807 wants to merge 2 commits intohatnote:masterfrom
ayushshukla1807:feat/health-check-and-modernize-public

Conversation

@ayushshukla1807
Copy link
Copy Markdown

This PR introduces several production-grade enhancements to the public API layer.

Changes:

  • Health Check Endpoint: Added GET /health to verify database connectivity. This is essential for modern container orchestration and uptime monitoring.
  • Security Hardening: Removed insecure hardcoded debug impersonation logic. Replaced with a structured allow_impersonation config flag that only functions in the dev environment.
  • Modernization: Added comprehensive type hints to public_endpoints.py and updated path handling using os.path.join for better cross-platform compatibility.
  • Refactoring: Cleaned up legacy TODO comments and unused logic in the login flow.

These changes significantly improve the security posture and maintainability of the public entry points.

@lgelauff
Copy link
Copy Markdown
Collaborator

lgelauff commented May 3, 2026

According to the docs, /meta seems to fulfill mostly the same functionality. Could you verify for duplication?

…s purpose vs /meta

Signed-off-by: Ayush Shukla <ayushshukla1807@gmail.com>
@ayushshukla1807
Copy link
Copy Markdown
Author

I've updated /health to return a 503 Service Unavailable on DB failure. While /meta provides app internals, this endpoint serves as a dedicated, public-facing probe for load balancers and external monitoring. All commits are now DCO-signed as well.

1 similar comment
@ayushshukla1807
Copy link
Copy Markdown
Author

I've updated /health to return a 503 Service Unavailable on DB failure. While /meta provides app internals, this endpoint serves as a dedicated, public-facing probe for load balancers and external monitoring. All commits are now DCO-signed as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants