feat: add /health check and modernize public endpoints#552
Open
ayushshukla1807 wants to merge 2 commits intohatnote:masterfrom
Open
feat: add /health check and modernize public endpoints#552ayushshukla1807 wants to merge 2 commits intohatnote:masterfrom
ayushshukla1807 wants to merge 2 commits intohatnote:masterfrom
Conversation
…nd harden login security
Collaborator
|
According to the docs, /meta seems to fulfill mostly the same functionality. Could you verify for duplication? |
…s purpose vs /meta Signed-off-by: Ayush Shukla <ayushshukla1807@gmail.com>
Author
|
I've updated /health to return a 503 Service Unavailable on DB failure. While /meta provides app internals, this endpoint serves as a dedicated, public-facing probe for load balancers and external monitoring. All commits are now DCO-signed as well. |
1 similar comment
Author
|
I've updated /health to return a 503 Service Unavailable on DB failure. While /meta provides app internals, this endpoint serves as a dedicated, public-facing probe for load balancers and external monitoring. All commits are now DCO-signed as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces several production-grade enhancements to the public API layer.
Changes:
GET /healthto verify database connectivity. This is essential for modern container orchestration and uptime monitoring.allow_impersonationconfig flag that only functions in thedevenvironment.public_endpoints.pyand updated path handling usingos.path.joinfor better cross-platform compatibility.TODOcomments and unused logic in the login flow.These changes significantly improve the security posture and maintainability of the public entry points.