Skip to content

Add "subgroup-size-control" feature#201

Draft
Jiawei-Shao wants to merge 1 commit into
gpuweb:mainfrom
Jiawei-Shao:add-subgroup-size-control
Draft

Add "subgroup-size-control" feature#201
Jiawei-Shao wants to merge 1 commit into
gpuweb:mainfrom
Jiawei-Shao:add-subgroup-size-control

Conversation

@Jiawei-Shao
Copy link
Copy Markdown
Contributor

This patch adds the "subgroup-size-control" feature in gpuweb/gpuweb#5578.

This patch adds the "subgroup-size-control" feature in
gpuweb/gpuweb#5578.
@Jiawei-Shao Jiawei-Shao requested review from Kangz and kainino0x May 13, 2026 02:16
@Jiawei-Shao
Copy link
Copy Markdown
Contributor Author

@kainino0x @Kangz PTAL, thanks!

@Jiawei-Shao
Copy link
Copy Markdown
Contributor Author

Hi @kainino0x and @Kangz ,

I cannot add subgroup-size-control because it hasn't been added to WebGPU SPEC and now CI requires the generated file must be up-to-date with gpuweb submodule.

@Kangz
Copy link
Copy Markdown
Contributor

Kangz commented May 13, 2026

Let's not merge this before the feature is added to the spec, we can use Typescript casts to coerce the string into the enum type and temporarily bypass the typechecks when writing the CTS.

@kainino0x
Copy link
Copy Markdown
Collaborator

I cannot add subgroup-size-control because it hasn't been added to WebGPU SPEC and now CI requires the generated file must be up-to-date with gpuweb submodule.

The generated file is meant to be purely generated, never edited manually. You only need to edit the dist file and let them be out of sync. (that's why we have both)

Let's not merge this before the feature is added to the spec, we can use Typescript casts to coerce the string into the enum type and temporarily bypass the typechecks when writing the CTS.

Generally I recommend changing types during the experimental phase, because writing CTS using typescript casts on things like experimental dictionaries and new methods is a pain. However in this case the amount of casting is trivial and wouldn't significantly complicate the tests. So, I'm fine either way.

@Jiawei-Shao Jiawei-Shao marked this pull request as draft May 14, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants