feat: add duration to health metrics#13181
Open
agrawal-siddharth wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ConnectionWorker to include a new windowDuration field in health check metrics and modifies the streamName logic to report "MULTIPLEXING" when multiplexing is active. The associated tests have been updated to reflect the changes in streamName. A review comment suggests adding assertions to verify that the new windowDuration field is correctly populated in the health check metrics.
Comment on lines
+1209
to
1210
| assertEquals("MULTIPLEXING", healthCheckFields.streamName); | ||
| assertEquals(connectionWorker.getWriterId(), healthCheckFields.writerId); |
Contributor
There was a problem hiding this comment.
The new windowDuration field added to the health metrics is not being verified in the tests. Consider adding an assertion to ensure it is correctly populated with the expected interval.
Suggested change
| assertEquals("MULTIPLEXING", healthCheckFields.streamName); | |
| assertEquals(connectionWorker.getWriterId(), healthCheckFields.writerId); | |
| assertEquals("MULTIPLEXING", healthCheckFields.streamName); | |
| assertEquals(connectionWorker.getWriterId(), healthCheckFields.writerId); | |
| assertEquals( | |
| ConnectionWorker.HEALTH_CHECK_INTERVAL.toString(), healthCheckFields.windowDuration); |
References
- When testing for metric generation, it is acceptable to assert the exact number of metrics to ensure no unexpected metrics are produced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.