Skip to content

docs: fix documentation drift — missing create-pull-request and add-pr-comment config fields#489

Merged
jamesadevine merged 2 commits into
mainfrom
docs/fix-safe-outputs-drift-f148044114e6539c
May 11, 2026
Merged

docs: fix documentation drift — missing create-pull-request and add-pr-comment config fields#489
jamesadevine merged 2 commits into
mainfrom
docs/fix-safe-outputs-drift-f148044114e6539c

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 9, 2026

Documentation Freshness Audit

This audit found the following inconsistencies between code and documentation:

Findings

Area Issue File(s)
create-pull-request config 7 config fields present in CreatePrConfig struct missing from docs docs/safe-outputs.md, prompts/create-ado-agentic-workflow.md
add-pr-comment agent params 3 agent parameters (line, start_line, status) missing from docs docs/safe-outputs.md
add-pr-comment config allowed-statuses config field missing from docs docs/safe-outputs.md

Details

create-pull-request missing config options (src/safeoutputs/create_pr.rs CreatePrConfig struct):

The following fields are accepted in front matter but not documented anywhere:

Field Default Description
title-prefix "" String prepended to every PR title
if-no-changes "warn" Behavior when patch is empty: warn, error, or ignore
max-files 100 Maximum files allowed in a single PR patch
protected-files "blocked" Whether pipeline/CI files can be modified (blocked/allowed)
excluded-files [] Glob patterns for files to exclude from the patch
allowed-labels [] Allowlist of labels the agent can apply (empty = any)
fallback-record-branch true Record branch name in failure data when PR creation fails

add-pr-comment missing items (src/safeoutputs/add_pr_comment.rs):

  • Agent params line, start_line, and status were missing — these enable inline comments with line ranges and custom thread status values
  • Config field allowed-statuses (restricts which status values the agent can set) was not documented

Applied Fixes

  • Added 7 missing create-pull-request config fields to docs/safe-outputs.md
  • Added missing create-pull-request config options to the example in prompts/create-ado-agentic-workflow.md Step 9
  • Added line, start_line, status agent params to add-pr-comment in docs/safe-outputs.md
  • Added allowed-statuses config field to add-pr-comment in docs/safe-outputs.md

This pull request was created by the automated documentation freshness check.

Generated by Documentation Freshness Check · ● 5.7M ·

…fields

Several configuration fields present in CreatePrConfig were missing from
docs/safe-outputs.md and prompts/create-ado-agentic-workflow.md:

- title-prefix: optional prefix prepended to PR titles
- if-no-changes: behavior when patch is empty (warn/error/ignore)
- max-files: maximum files per PR patch (default: 100)
- protected-files: policy for pipeline/CI file modifications (blocked/allowed)
- excluded-files: glob patterns to exclude from the patch
- allowed-labels: allowlist of labels the agent can apply
- fallback-record-branch: record branch in failure data (default: true)

Also document missing add-pr-comment agent parameters (line, start_line,
status) and the allowed-statuses config field.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jamesadevine jamesadevine marked this pull request as ready for review May 11, 2026 09:21
@jamesadevine
Copy link
Copy Markdown
Collaborator

@copilot resolve the merge conflicts in this pull request

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 11, 2026

@copilot resolve the merge conflicts in this pull request

Resolved and pushed in commit 8a10d86. I merged latest origin/main, fixed the conflict in docs/safe-outputs.md, and verified with cargo test, cargo clippy --all-targets --all-features, and validation checks.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • spsprodeus21.vssps.visualstudio.com
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 .d8b28416bc2ef292-cgu.1.rcgu.o .d8b28416bc2ef292-cgu.2.rcgu.o .d8b28416bc2ef292-cgu.3.rcgu.o .d8b28416bc2ef292-cgu.4.rcgu.o .d8b28416bc2ef292-cgu.5.rcgu.o .05o5yxfpdnns7dvmqtkq3cl7v.09d4wwh.rcgu.o .0rs20y679ogftwp6hvy6kz2kn.09d4wwh.rcgu.o .0t59kqy3had954v1nj55vvzor.09d4wwh.rcgu.o .1jfa7zn1wvg90gtafqcnuvvdp.09d4wwh.rcgu.o .1jfbzkka4s8c9zbgenyzp9qca.09d4wwh.rcgu.o .1lv9nbkph6susf4ioixemvnrm.09d4wwh.rcgu.o .1nkssbntk2etip7qbmul5vt08.09d4wwh.rcgu.o .1pwtpr5rv2958uanfl895250m.09d4wwh.rcgu.o .1tqokxs2atpyyh0j3a5jx8yms.09d4wwh.rcgu.o .208vfdai33n0gpqg4l1kdlzo9.09d4wwh.rcgu.o .2jdi5ky8gjgd29ino23xlf9sv.09d4wwh.rcgu.o .2tsl8g5dlpytwkxldeiozrj62.09d4wwh.rcgu.o .357bf21auvadvoaybpxcrxilo.09d4wwh.rcgu.o .3gerarymmb52u6zx5v2m2ng43.09d4wwh.rcgu.o (dns block)
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/libsyn-1500b8e8e9aaac8c.rlib /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/libquote-de7a5136bc698ae7.rlib/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/bash_lint_tests-519976ce551c8145.2bikq83kqxzd59u4d0aoev3vs.1cdg0mm.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/libproc_macro2-4f0f17ff7b9c793/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/bash_lint_tests-519976ce551c8145.2boqvweqww93ilwsx0c22c3r0.1cdg0mm.rcgu.o 0ja.�� r&#34;, &#34;equivalent&#34;, &#34;inline-more&#34;, &#34;nightly&#34;, &#34;raw-entry&#34;, &#34;rayon&#34;, &#34;rustc-dep-of-/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/bash_lint_tests-519976ce551c8145.2hkf7twmmm5z0ktz2vjsee9ue.1cdg0mm.rcgu.o 0ja.rcgu.o bin/rustc 0ja.rcgu.o 0ja.rcgu.o k/ado-aw/ado-aw/-Wl,--no-undefined-version bin/rustc k/ad�� k/ado-aw/ado-aw//home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/derive_more_impl-46e9b1cf09dfacc k/ado-aw/ado-aw//home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/derive_more_impl-46e9b1cf09dfa-m64 bin/rustc k/ado-aw/ado-aw/bash 7bytgpjb88a.1inu--norc 32onkzo83vi.1inu--noprofile bin/rustc (dns block)
  • spsprodweu4.vssps.visualstudio.com
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 .d8b28416bc2ef292-cgu.1.rcgu.o .d8b28416bc2ef292-cgu.2.rcgu.o .d8b28416bc2ef292-cgu.3.rcgu.o .d8b28416bc2ef292-cgu.4.rcgu.o .d8b28416bc2ef292-cgu.5.rcgu.o .05o5yxfpdnns7dvmqtkq3cl7v.09d4wwh.rcgu.o .0rs20y679ogftwp6hvy6kz2kn.09d4wwh.rcgu.o .0t59kqy3had954v1nj55vvzor.09d4wwh.rcgu.o .1jfa7zn1wvg90gtafqcnuvvdp.09d4wwh.rcgu.o .1jfbzkka4s8c9zbgenyzp9qca.09d4wwh.rcgu.o .1lv9nbkph6susf4ioixemvnrm.09d4wwh.rcgu.o .1nkssbntk2etip7qbmul5vt08.09d4wwh.rcgu.o .1pwtpr5rv2958uanfl895250m.09d4wwh.rcgu.o .1tqokxs2atpyyh0j3a5jx8yms.09d4wwh.rcgu.o .208vfdai33n0gpqg4l1kdlzo9.09d4wwh.rcgu.o .2jdi5ky8gjgd29ino23xlf9sv.09d4wwh.rcgu.o .2tsl8g5dlpytwkxldeiozrj62.09d4wwh.rcgu.o .357bf21auvadvoaybpxcrxilo.09d4wwh.rcgu.o .3gerarymmb52u6zx5v2m2ng43.09d4wwh.rcgu.o (dns block)
    • Triggering command: /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-3136f96127ec4700 /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/libsyn-1500b8e8e9aaac8c.rlib /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/libquote-de7a5136bc698ae7.rlib/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/bash_lint_tests-519976ce551c8145.2bikq83kqxzd59u4d0aoev3vs.1cdg0mm.rcgu.o /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/libproc_macro2-4f0f17ff7b9c793/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/bash_lint_tests-519976ce551c8145.2boqvweqww93ilwsx0c22c3r0.1cdg0mm.rcgu.o 0ja.�� r&#34;, &#34;equivalent&#34;, &#34;inline-more&#34;, &#34;nightly&#34;, &#34;raw-entry&#34;, &#34;rayon&#34;, &#34;rustc-dep-of-/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/bash_lint_tests-519976ce551c8145.2hkf7twmmm5z0ktz2vjsee9ue.1cdg0mm.rcgu.o 0ja.rcgu.o bin/rustc 0ja.rcgu.o 0ja.rcgu.o k/ado-aw/ado-aw/-Wl,--no-undefined-version bin/rustc k/ad�� k/ado-aw/ado-aw//home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/derive_more_impl-46e9b1cf09dfacc k/ado-aw/ado-aw//home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/derive_more_impl-46e9b1cf09dfa-m64 bin/rustc k/ado-aw/ado-aw/bash 7bytgpjb88a.1inu--norc 32onkzo83vi.1inu--noprofile bin/rustc (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI requested a review from jamesadevine May 11, 2026 09:39
@jamesadevine jamesadevine merged commit 83c95f0 into main May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants