Fix custom_properties diffing when config uses property_name

[Copilot]

Bug Fix

What was the bug?

custom_properties entries in repo/suborg YAML were ignored when authored with property_name instead of name. As a result, safe-settings did not detect/add expected property values (for example, ent-ownership: expert-services).

How did you fix it?

• Normalize config entries across both key shapes

  • Updated CustomProperties.normalizeEntries() to accept either name or property_name from config entries.
  • Kept normalization behavior consistent by lowercasing the resolved property key before diffing.

• Harden entry handling

  • Added guards to skip invalid/non-object entries and entries without a valid string key.

• Add regression coverage

  • Extended custom properties unit tests to cover config entries defined with property_name.

Testing

• Added/updated unit coverage in test/unit/lib/plugins/custom_properties.test.js for property_name-based config input.

custom_properties:
  - property_name: ent-ownership
    value: expert-services

This now normalizes to the same internal shape as name, so the diff logic detects and applies the property update.

[Copilot]

Pull request overview

Fixes a diffing bug in the custom_properties plugin where config entries authored with property_name (instead of name) were not normalized consistently, causing intended property updates to be missed.

Changes:

• Updated config entry normalization to accept both name and property_name and lowercase the resolved key prior to diffing.
• Hardened normalization of fetched custom properties to handle both property_name and name shapes and skip invalid entries.
• Added Jest regression tests covering property_name in config and mixed response shapes during pagination normalization.

Show a summary per file

File	Description
lib/plugins/custom_properties.js	Extends normalization logic to accept both name and property_name, adds basic guards, and ensures lowercased keys are used for comparisons.
test/unit/lib/plugins/custom_properties.test.js	Adds regression coverage for property_name-based config input and mixed key shapes in paginated results.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comments suppressed due to low confidence (1)

lib/plugins/custom_properties.js:68

• Same issue as in normalizeEntries: property.property_name || property.name will ignore a valid name/property_name if the first field is present but non-string and truthy. Prefer checking typeof for each candidate and using the first string value to avoid silently dropping valid records.

      const propertyName = property.property_name || property.name

      if (typeof propertyName !== 'string') {
        return normalizedProperties
      }

      normalizedProperties.push({
        name: propertyName.toLowerCase(),
        value: property.value

• Files reviewed: 2/2 changed files
• Comments generated: 2