Restores underlines to links in the content

[aardrian]

/assets/css/index.css has this code, which removes underlines from all links on the page:

a {
  color: #0366d6;
  text-decoration: none;
}

I cannot find that file in the repo, so I've made my change to the custom.scss file.

This update reverts the underline removal for content links. Otherwise the links fail SC 1.4.1 Use of Color because, while the underline-on-hover style elsewhere suggests someone was trying to pass it via Technique G183, the contrast ratio between the blue link and black text is only 2.7:1.

This change fixes the WCAG violation and also provides demonstrably more usable links ("demonstrably" because I can point to research if needed).

• Have you followed the contributing guidelines?
• Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

---

[mgifford]

Thanks for reporting it here.

[ahpook]

This style is computed from the upstream Primer design system's primer-base module, which is why you didn't see it in the repo. A fix should probably go upstream, but we're pinned to a very old version of Primer for this site so this seems like a good workaround.