feat: replace server instructions with skill resources#2374
Draft
SamMorrowDrums wants to merge 1 commit intomainfrom
Draft
feat: replace server instructions with skill resources#2374SamMorrowDrums wants to merge 1 commit intomainfrom
SamMorrowDrums wants to merge 1 commit intomainfrom
Conversation
Replace the server instructions system with MCP skill resources that follow the skill:// URI convention for discovery by MCP clients. Each skill resource covers a domain of tools and provides YAML frontmatter (name, description, allowed-tools) plus markdown guidance. All tools remain available by default (all tools mode). Skills provide contextual guidance that clients can discover via resources/list. 16 skills covering all toolsets: context, repos, issues, pull-requests, code-security, actions, discussions, projects, notifications, gists, users-orgs, security-advisories, labels, git, stargazers, copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
118f25c to
2140dd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the server instructions system with MCP skill resources that follow the
skill://URI convention, enabling MCP clients (like pi-mcp-agent) to discover and load domain-specific guidance on demand.Related: https://github.com/SamMorrowDrums/pi-mcp-agent/issues/2
What changed
Added
pkg/github/skill_resources.go— 16 skill resources covering all toolsets, registered asskill://github/{name}/SKILL.mdstatic resourcespkg/github/skill_resources_test.go— tests verifying all tools are covered, content format, URI uniqueness, and registrationRemoved
InstructionsFunconToolsetMetadata,generateInstructions(),WithServerInstructions()builder method, and theInstructionsfield from MCP server optionspkg/github/toolset_instructions.go— instruction generator functionspkg/inventory/instructions.go— thegenerateInstructionsfunctionpkg/inventory/instructions_test.go— associated testsSkills created (16 total)
contextreposissuespull-requestscode-securityactionsdiscussionsprojectsnotificationsgistsusers-orgssecurity-advisorieslabelsgitstargazerscopilotHow it works
skill://github/{name}/SKILL.mdURIsresources/list(filtering forskill://URIs)name,description, andallowed-toolsTesting
script/lint✅script/test✅ (all tests pass)