Add update_pull_request_branches maintenance operation with dedicated workflow job#28108
Draft
Add update_pull_request_branches maintenance operation with dedicated workflow job#28108
Conversation
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e1b6217e-c851-487f-8690-a75028715f5d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e1b6217e-c851-487f-8690-a75028715f5d Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
pelikhan
April 23, 2026 14:11
View session
pelikhan
reviewed
Apr 23, 2026
| /** | ||
| * @returns {Promise<Set<number>>} | ||
| */ | ||
| async function listPullRequestsWithActiveSessions() { |
Contributor
Author
There was a problem hiding this comment.
Updated to explicitly filter to PRs without active sessions before branch updates (new filterPullRequestsWithoutActiveSessions path + test coverage). Addressed in commit a003433.
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/dfc1d53a-7fec-47e2-a76a-9ecbf4a15d73 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/dfc1d53a-7fec-47e2-a76a-9ecbf4a15d73 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
@copilot gh is not available, do a REST API call instead of "gh tasklist" See https://github.com/github/gh-aw/actions/runs/24844850181/job/72728893323#step:7:1 |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/009352de-ca04-4409-8eaa-4bd19ccad058 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Switched session discovery off Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
@copilot add more logging calls using core.* |
Collaborator
|
@copilot move to separate job to avoid polluting the list of required permissions |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/42605c79-7ebd-428c-9727-efe4ae592077 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/42605c79-7ebd-428c-9727-efe4ae592077 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/42605c79-7ebd-428c-9727-efe4ae592077 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/42605c79-7ebd-428c-9727-efe4ae592077 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Added additional Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/71dcefc7-2a67-4995-829b-60e155f10fc2 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Collaborator
|
Contributor
Author
Done in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add update_pull_request_branches maintenance operation
Add update_pull_request_branches maintenance operation with dedicated workflow job
Apr 23, 2026
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9f795926-947f-4df9-8e2e-4320c796cccb Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Addressed in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
Hey
|
pelikhan
reviewed
Apr 23, 2026
| with: | ||
| destination: ${{ runner.temp }}/gh-aw/actions | ||
|
|
||
| - name: Check admin/maintainer permissions |
Collaborator
There was a problem hiding this comment.
@copilot pass the GitHub token to any step using GitHub APIs to avoid rate limiting, include admin check and logs download
Contributor
Author
There was a problem hiding this comment.
Addressed in a40c8ae: all maintenance Check admin/maintainer permissions github-script steps now receive GH_TOKEN in env, and the activity-report logs download step already passes GH_TOKEN. Added regression coverage in TestGenerateMaintenanceWorkflow_AdminCheckPassesGHTokenEnv to keep this enforced.
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/7ebeb219-18a9-4b7b-b7c0-d88853047007 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/c14085cc-c356-452e-bc47-4b5d0629b950 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
|
Done in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
update_pull_request_branchesactions/setup/js/update_pull_request_branches.cjsupdate_pull_request_branchesexecution to a dedicatedupdate_pull_request_branchesjob in maintenance workflow generation to isolate permissionsrun_operationconditions andrun_operation_update_upgrade.cjssorun_operationno longer handlesupdate_pull_request_branches.github/workflows/agentics-maintenance.yml)Validation
make fmtmake recompilenpm test -- run_operation_update_upgrade.test.cjs update_pull_request_branches.test.cjs(fromactions/setup/js)go test -v -run "TestGenerateMaintenanceWorkflow_OperationJobConditions|TestGenerateMaintenanceWorkflow_RunOperationCLICodegen" ./pkg/workflow/make agent-finish(currently fails due pre-existing workflow package test failures unrelated to this change:TestCopilotDetectionDefaultModelandTestWasmGolden_CompileFixtures)Notes
parallel_validationcompleted Code Review successfully after feedback updates🤖 Smoke CI scheduled run: https://github.com/github/gh-aw/actions/runs/24841939453
> Generated by Smoke CI · ● 396.7K · ◷