Go: improve accuracy of overlay annotations#21740
Open
owen-mc wants to merge 1 commit intogithub:mainfrom
Open
Go: improve accuracy of overlay annotations#21740owen-mc wants to merge 1 commit intogithub:mainfrom
owen-mc wants to merge 1 commit intogithub:mainfrom
Conversation
832ab71 to
e37e103
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Go QL library overlays and crypto modeling to improve annotation accuracy and make encryption-operation modeling use explicit flow-target accessors.
Changes:
- Refactors
Cryptography::EncryptionOperationto requiregetEncryptionFlowTarget()and updates subclasses accordingly. - Adjusts overlay annotations (for example
overlay[local?]andoverlay[global]) on selected Go library modules/members to improve overlay behavior. - Updates crypto/cipher StreamReader/StreamWriter models to provide explicit encryption-target and input nodes via overrides.
Show a summary per file
| File | Description |
|---|---|
| go/ql/lib/semmle/go/frameworks/CryptoLibraries.qll | Updates crypto/cipher stream operation models to override the new encryption flow target accessor and provide inputs explicitly. |
| go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll | Tweaks overlay annotations and marks selected call-target resolution helpers as overlay[global]. |
| go/ql/lib/semmle/go/Scopes.qll | Updates module overlay annotation and marks Function.getACall() as overlay[global]. |
| go/ql/lib/semmle/go/Decls.qll | Updates module overlay annotation and marks FuncDef.getACall() as overlay[global]. |
| go/ql/lib/semmle/go/Concepts.qll | Refactors EncryptionOperation to use an abstract getEncryptionFlowTarget() and updates EncryptionMethodCall accordingly. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 0
Co-authored-by: Copilot <copilot@github.com>
e37e103 to
710c1ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FuncDef.getACall()should beoverlay[global]. This reduces the number of alerts that we miss in overlay mode.I did 4 DCA runs, but only runs 3 and 4 need to be considered.
EncryptionOperation#21745.