Skip to content

Remove dual Hermes version outputs from CI workflows (#56739)#56739

Open
cipolleschi wants to merge 5 commits intofacebook:mainfrom
cipolleschi:export-D104381269
Open

Remove dual Hermes version outputs from CI workflows (#56739)#56739
cipolleschi wants to merge 5 commits intofacebook:mainfrom
cipolleschi:export-D104381269

Conversation

@cipolleschi
Copy link
Copy Markdown
Contributor

@cipolleschi cipolleschi commented May 8, 2026 •
edited by meta-codesync Bot
Loading

Summary:

Summary

  • Simplify publish-release.yml: remove HERMES_V1_VERSION output, read only HERMES_VERSION_NAME
  • Simplify create-draft-release.yml: remove hermesV1Version input
  • Simplify createDraftRelease.js: remove hermesV1Version parameter and "Hermes V1 dSYMS" section from release notes
  • Simplify prebuild-ios-core.yml: read HERMES_VERSION_NAME instead of HERMES_V1_VERSION_NAME
  • Delete unused prepare-hermes-v1-app action, hermes-v1.patch, and selectLatestHermesV1Version.js

Changelog:

[Internal]

Test plan

  • JS tests: yarn jest --no-watchman createDraftRelease-test.js — 9/9 tests pass

Reviewed By: cortinico

Differential Revision: D104381269

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@facebook-github-tools facebook-github-tools Bot added p: Facebook Partner: Facebook Partner labels May 8, 2026
@meta-codesync
Copy link
Copy Markdown

meta-codesync Bot commented May 8, 2026

@cipolleschi has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104381269.

@meta-codesync meta-codesync Bot changed the title Remove dual Hermes version outputs from CI workflows Remove dual Hermes version outputs from CI workflows (#56739) May 8, 2026
@cipolleschi cipolleschi force-pushed the export-D104381269 branch from a605b2a to e14a0ab Compare May 8, 2026 17:06
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 8, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
e14a0ab 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
c1b9419 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
f008edf 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
d64b0fe 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
587123b 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
7e73f92 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
@cipolleschi cipolleschi force-pushed the export-D104381269 branch 2 times, most recently from 7e73f92 to b70f49d Compare May 11, 2026 11:12
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
b70f49d 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Differential Revision: D104381269
cortinico
cortinico approved these changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
043d343 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Reviewed By: cortinico

Differential Revision: D104381269
Riccardo Cipolleschi and others added 4 commits May 11, 2026 07:30
@meta-codesync
Generated from a GitHub Pull Request. Run 'jf sync' on this diff to l…
a43c396 
…oad the correct commit data.

Differential Revision: D104228879
@meta-codesync
Generated from a GitHub Pull Request. Run 'jf sync' on this diff to l…
994091e 
…oad the correct commit data.

Differential Revision: D104244582
@meta-codesync
Remove RCT_HERMES_V1_ENABLED from CocoaPods infrastructure (facebook#…
ce68600 
…56735)

Summary:
Pull Request resolved: facebook#56735

  - Remove `RCT_HERMES_V1_ENABLED` environment variable from `react_native_pods.rb`
  - Simplify `jsengine.rb` to always use `.hermesversion` tag file
  - Remove conditional `HERMES_V1_ENABLED=1` preprocessor definition from `utils.rb`
  - Simplify `hermes-engine.podspec`: always read `HERMES_VERSION_NAME`, use V1 source files, remove legacy inspector subspecs
  - Simplify `hermes-utils.rb`: remove `hermes_v1_enabled()` function, always use `250829098.0.0-stable` branch, always use `.hermesversion` tag file

## Changelog:
[iOS][Removed] - Remove the RCT_HERMES_V1_ENABLED from Cocoapods

  ## Test plan
  - [x] iOS: `bundle exec pod install` — success
  - [x] iOS: `xcodebuild` rn-tester on iPhone 16 Pro simulator — BUILD SUCCEEDED

Differential Revision: D104247277

Reviewed By: cortinico
@cipolleschi @meta-codesync
Intermediate commit for 1778507110
c77e84a 
Differential Revision: D104380961
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
fd0ab16 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Reviewed By: cortinico

Differential Revision: D104381269
cipolleschi added a commit to cipolleschi/react-native that referenced this pull request May 11, 2026
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
fcb0f5d 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Reviewed By: cortinico

Differential Revision: D104381269
@cipolleschi @meta-codesync
Remove dual Hermes version outputs from CI workflows (facebook#56739)
3c17c57 
Summary:
Pull Request resolved: facebook#56739

## Summary
  - Simplify `publish-release.yml`: remove `HERMES_V1_VERSION` output, read only `HERMES_VERSION_NAME`
  - Simplify `create-draft-release.yml`: remove `hermesV1Version` input
  - Simplify `createDraftRelease.js`: remove `hermesV1Version` parameter and "Hermes V1 dSYMS" section from release notes
  - Simplify `prebuild-ios-core.yml`: read `HERMES_VERSION_NAME` instead of `HERMES_V1_VERSION_NAME`
  - Delete unused `prepare-hermes-v1-app` action, `hermes-v1.patch`, and `selectLatestHermesV1Version.js`

## Changelog:
[Internal]

  ## Test plan
  - [x] JS tests: `yarn jest --no-watchman createDraftRelease-test.js` — 9/9 tests pass

Reviewed By: cortinico

Differential Revision: D104381269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cipolleschi @cortinico