Fix predeclare from buildscript in gradle 9.x#2929
Open
bric3 wants to merge 3 commits into
Open
Conversation
Gradle 9 rejects mutating the root `buildscript` configuration container during task execution. This breaks `predeclareDepsFromBuildscript()` because Spotless resolved formatter dependencies by calling `ConfigurationContainer.create(...)` from `:spotlessInternalRegisterDependencies`. This commit makes spotless resolve the formatter dependencies with a detached configurations instead. They are not added to the target configuration container, so they avoid the Gradle 9 mutation guard while still using the repositories from the same configuration context. Also adds a Gradle 9.5.1 integration test for the legacy `predeclareDepsFromBuildscript()` path. https://docs.gradle.org/current/userguide/upgrading_version_8.html#mutating_buildscript_configurations https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/ConfigurationContainer.html#detachedConfiguration-org.gradle.api.artifacts.Dependency...- Fixes diffplug#2599
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle 9 rejects mutating the root
buildscriptconfiguration container during task execution. This breakspredeclareDepsFromBuildscript()because Spotless resolved formatter dependencies by callingConfigurationContainer.create(...)from:spotlessInternalRegisterDependencies.This commit makes spotless resolve the formatter dependencies with a detached configurations instead.
They are not added to the target configuration container, so they avoid the Gradle 9 mutation guard while still using the repositories from the same configuration context.
Also adds a Gradle 9.5.1 integration test for the legacy
predeclareDepsFromBuildscript()path.https://docs.gradle.org/current/userguide/upgrading_version_8.html#mutating_buildscript_configurations
https://docs.gradle.org/current/javadoc/org/gradle/api/artifacts/ConfigurationContainer.html#detachedConfiguration-org.gradle.api.artifacts.Dependency...-
Fixes #2599