Skip to content

ci: require plugin version bump for any plugin change#10

Open
myasnikovdaniil wants to merge 1 commit into
mainfrom
ci/check-plugin-version-bump
Open

ci: require plugin version bump for any plugin change#10
myasnikovdaniil wants to merge 1 commit into
mainfrom
ci/check-plugin-version-bump

Conversation

@myasnikovdaniil
Copy link
Copy Markdown
Contributor

Summary

PR #9 changed skills/cozystack-upgrade/SKILL.md without bumping plugin.json .version, and nothing in CI caught it. This adds an automated check so the same gap doesn't recur.

  • .github/workflows/check-plugin-version-bump.yml — on PRs touching agents/, hooks/, mcp/, or skills/, asserts that every modified plugin's .claude-plugin/plugin.json .version is strictly greater (by sort -V) than on the base branch. New plugins (no manifest on base) are exempted. Failures emit a ::error file=… annotation pointing at the offending manifest.
  • CLAUDE.md — documents the convention under a new ## Modifying an Existing Plugin section.

Test plan

  • CI green on this PR itself (no plugin files changed → workflow short-circuits with "No plugin files changed — nothing to check.")
  • Open a follow-up PR that touches a skills/<name>/ file without bumping the manifest and confirm this workflow fails it

🤖 Generated with Claude Code

Adds a `Check plugin version bump` workflow that runs on PRs touching
`agents/`, `hooks/`, `mcp/`, or `skills/`. For each `<category>/<name>/`
directory with changes in the PR, it asserts that `<category>/<name>/
.claude-plugin/plugin.json` `.version` is strictly greater (by `sort -V`)
than the version on the base branch. New plugins (no manifest on base)
are exempted. The check is hard-failed (`exit 1`) with a clear inline
annotation pointing at the offending manifest.

Documents the convention in `CLAUDE.md` so contributors see the
expectation when modifying a plugin.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: Myasnikov Daniil <myasnikovdaniil2001@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 14, 2026

Warning

Rate limit exceeded

@myasnikovdaniil has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 59 minutes and 48 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4c32532f-91bc-4306-8145-16d0e831c812

📥 Commits

Reviewing files that changed from the base of the PR and between d97a3d4 and 2408481.

📒 Files selected for processing (2)
  • .github/workflows/check-plugin-version-bump.yml
  • CLAUDE.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/check-plugin-version-bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates CLAUDE.md to document the requirement for version bumps when modifying existing plugins. The feedback highlights that the GitHub Actions workflow mentioned in the documentation is missing from the current changes. It is also suggested to clarify that this rule applies specifically to updates of existing plugins to avoid confusion for contributors adding new ones.

Comment thread CLAUDE.md
Comment thread CLAUDE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant