views.py: Fix port in URL for setup / downloads-zip#239
Open
Eckert-IT wants to merge 1 commit intobryangerlach:masterfrom
Open
views.py: Fix port in URL for setup / downloads-zip#239Eckert-IT wants to merge 1 commit intobryangerlach:masterfrom
Eckert-IT wants to merge 1 commit intobryangerlach:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your are on the self hosted version and <our URL contains an specific port, you get an issue qithin the workflow and [setup / download-zip].
E.g. URL: https://www.my-domain.com:4433 --> [setup / download-zip] won't work, because
input_data = json.loads('{"url": "https://www.my-domain.com/" ...This is issued by line 103 in rdgen / rdgenerator / views.py using
full_url = f"{protocol}://{host}"I changed ist to
full_url = f"{protocol}://{host}" if _settings.GENURL else f"{_settings.PROTOCOL}://{request.get_host()}"and now it works (2 time test run).