Fix: Make workflows resilient to status API overloads (continue-on-error)#218
Open
thotganesh wants to merge 21 commits intobryangerlach:masterfrom
Open
Fix: Make workflows resilient to status API overloads (continue-on-error)#218thotganesh wants to merge 21 commits intobryangerlach:masterfrom
thotganesh wants to merge 21 commits intobryangerlach:masterfrom
Conversation
Updated macOS workflow to improve app icon handling and build process.
Updated the macOS workflow to include additional steps for icon handling, app signing, and DMG creation. Enhanced error handling and reporting for various stages of the build process.
Removed commented-out lines and cleaned up the environment variables section. Adjusted some steps for clarity and consistency.
Removed commented-out lines and unnecessary comments in the workflow file. Updated environment variable handling for Rust versions and VCPKG commit IDs.
Updated environment variables and improved error handling in the workflow.
Updated README to reflect new project features and installation instructions.
Removed redundant steps for source code checkout and binary handling in the CI workflow.
Updated the workflow to use Ubuntu 22.04 and made various adjustments to the steps for building and deploying the Flatpak package.
Updated the macOS app signing process to include entitlements for security permissions and improved error handling for executable signing.
Removed installation of rcodesign tool and updated signing process for macOS app bundle to use Keychain.
Updated build script to include deep signing and modified comments for clarity.
Removed the '--no-sign' argument from the build.py command in the macOS generator workflow.
Updated build script to include no-sign option and refined signing process.
Updated macOS workflow to install rcodesign tool and modified signing process for the app bundle.
Updated code signing process for macOS application with new entitlements and cleanup of temporary files.
Removed installation steps for rcodesign tool and updated signing process for macOS app bundle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Bryan,
As we discussed, I've implemented a fix for the build failures caused by the status server being overloaded.
The Problem:
Currently, if the rdgen.crayoneater.org API returns a 5xx error or timeouts, the entire GitHub Action workflow fails, preventing the final artifacts from being generated.
The Fix:
I've added continue-on-error: true to all steps using fjogeleit/http-request.
This ensures that the build proceeds to completion even if the status update fails. I've verified this on my fork and it works perfectly.
Thanks for the great work on this project!
Update:
In addition to the status server fix, I have also resolved the persistent GNU Linux (x86_64) build failure:
Flatpak Environment: Updated the build matrix to ubuntu-22.04 to support modern Flathub runtimes.
Path Management: Fixed internal directory paths for Flatpak bundle generation.
Build Stability: Verified that both .deb and .flatpak targets for GNU Linux are now compiling and uploading successfully. All Linux targets are now 100% operational.