Skip to content

Small "hack" to make AutoUpdater download from custom url#145

Open
Maxetto wants to merge 3 commits intobryangerlach:masterfrom
Maxetto:updater-hack
Open

Small "hack" to make AutoUpdater download from custom url#145
Maxetto wants to merge 3 commits intobryangerlach:masterfrom
Maxetto:updater-hack

Conversation

@Maxetto
Copy link
Copy Markdown
Contributor

@Maxetto Maxetto commented Oct 21, 2025

Not the best approach, but as long as you have set the correct custom url for download updates and it points directly to a file it will make the new autoupdater introduced in 1.4.0 download the correct version.

Previously it would download the official unmodified version, breaking the custom values the client had.

A proper way would be to use a patch file, but I have no idea how >.<

@bryangerlach
Copy link
Copy Markdown
Owner

Does this not work on linux or android? I haven't look into it at all. Does this change how the client checks for updates, or is it still checking based on official rustdesk versions?

@Maxetto
Copy link
Copy Markdown
Contributor Author

Maxetto commented Oct 24, 2025

For now it seems only Windows and MacOS have this feature. Android I can confirm it still open a webpage with the url you set, Linux I don't know.
The PR that added the feature was that: rustdesk/rustdesk#11618

It only changes the download url, all the update check logic still follows the official rustdesk versions.

@Maxetto
Copy link
Copy Markdown
Contributor Author

Maxetto commented Oct 24, 2025

https://github.com/rustdesk/rustdesk/blob/965cb704ecc7fcb408416949e9e68bba646d43d2/flutter/lib/desktop/widgets/update_progress.dart#L24
downloadUrl = '$downloadUrl/$downloadFile';

Actually maybe it could work by just replacing this line instead of messing with many lines of flutter_ffi.rs 🤔

@k3-cat
Copy link
Copy Markdown

k3-cat commented Nov 9, 2025

Hi,

Sorry for open the issue #149 without checking this PR. Thanks for all your workings.
However, I feel that proposal in 149 might provide a more seamless experience yet not potentially breaks future builds as well.

If we all feel happy about it, I am more than welcome to write a git patch file or sed commands.

@wandesoncarvalho
Copy link
Copy Markdown

Does this not work on linux or android? I haven't look into it at all. Does this change how the client checks for updates, or is it still checking based on official rustdesk versions?

Resp: “It does work on Android, but it’s still in an experimental stage.”

@djrarky
Copy link
Copy Markdown

djrarky commented Apr 7, 2026

Hi @bryangerlach , is this pull request something you're able to consider?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants