u-boot: 2026.04: drop #warnings in fdt_fixup_ethernet logging patch

[rpardini]

• 🌿 those were added to ensure that code was actually being compiled
• 🌴 we're pretty sure now, so avoid spurious warnings during compilation

Summary by CodeRabbit

• Chores
  • Enhanced diagnostic logging throughout the Ethernet boot device tree setup process, including operation counts and detailed reasons for skipped operations.
  • Replaced compile-time warnings with runtime logging for improved visibility and troubleshooting during the boot sequence.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds comprehensive logging instrumentation to the Ethernet FDT fixup flow, tracking function entry, alias discovery, skip reasons, and patch operations. Replaces compile-time warnings in FDT image setup with weak stub functions that log invocations, providing runtime visibility into board and system FDT setup operations.

Changes

Cohort / File(s)	Summary
FDT Ethernet Fixup Instrumentation boot/fdt_support.c	Enhanced fdt_fixup_ethernet with detailed logging for function entry, /aliases discovery, per-alias metadata, skip reasons (invalid index, disabled node, missing env var, missing path, status not okay), patch operations with computed MAC addresses, and summary counters.
FDT Image Setup Logging boot/image-fdt.c	Replaced compile-time #warning directives with weak stub implementations (arch_fixup_fdt, ft_board_setup, ft_system_setup) that log when invoked. Added runtime logging around calls to FDT fixup and setup functions during image_setup_libfdt.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A patch with logs and tales to tell,
Of Ethernet nodes and aliases dwell,
With counters tallied, reasons why skipped,
The FDT flows where weak stubs grip,
Now every fixup sings with pride! 🌳

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing #warning directives from the fdt_fixup_ethernet logging patch in u-boot 2026.04.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@patch/u-boot/v2026.04/1001-fdt_fixup_ethernet-add-logs.patch`:
- Around line 130-132: Remove the stray empty line inserted before the SPDX
header so that the comment "// SPDX-License-Identifier: GPL-2.0+" is the very
first line of the file; specifically, drop the added leading blank line from the
hunk that prepended an empty line before the SPDX tag in boot/image-fdt.c so the
SPDX header resumes being on line 1.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 36a62389-5221-472b-8c5b-4203e99e76a4

📥 Commits

Reviewing files that changed from the base of the PR and between 2bb89c7 and aaa5b22.

📒 Files selected for processing (1)

• patch/u-boot/v2026.04/1001-fdt_fixup_ethernet-add-logs.patch

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!