Skip to content

armbian-resize-filesystem: fix typo $rootdev → $diskdev in do_expand_partition#9702

Open
iav wants to merge 1 commit intoarmbian:mainfrom
iav:fix/resize-filesystem-rootdev
Open

armbian-resize-filesystem: fix typo $rootdev → $diskdev in do_expand_partition#9702
iav wants to merge 1 commit intoarmbian:mainfrom
iav:fix/resize-filesystem-rootdev

Conversation

@iav
Copy link
Copy Markdown
Contributor

@iav iav commented Apr 20, 2026

Typo fix: $rootdev is undefined in do_expand_partition — should be $diskdev.

Fixes #9594

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of automatic reboot scheduling during filesystem resize operations on specific kernel versions.

$rootdev is undefined in do_expand_partition; should be $diskdev.

Fixes armbian#9594

Assisted-by: Claude:claude-opus-4-7
@iav iav requested a review from a team as a code owner April 20, 2026 03:42
@iav iav requested review from PanderMusubi and matthijskooijman and removed request for a team April 20, 2026 03:42
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e10e1a8-c174-4cc2-9083-ff64581be179

📥 Commits

Reviewing files that changed from the base of the PR and between 3814034 and d76520c.

📒 Files selected for processing (1)
  • packages/bsp/common/usr/lib/armbian/armbian-resize-filesystem

📝 Walkthrough

Walkthrough

A bug fix corrects an undefined variable reference in the do_expand_partition() function. The partprobe call that conditionally triggers a filesystem reboot now references the correct disk device variable instead of an undefined root filesystem device variable.

Changes

Cohort / File(s) Summary
Bug Fix
packages/bsp/common/usr/lib/armbian/armbian-resize-filesystem
Corrected undefined variable reference in partprobe call from $rootdev to $diskdev within do_expand_partition() function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A variable lost, undefined and forlorn,
But spotted with care on a code review morn,
From rootdev to diskdev, the correction rings true,
One line, one fix, makes the script shine anew! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately identifies the fix as correcting a typo where $rootdev should be $diskdev in the do_expand_partition function.
Linked Issues check ✅ Passed The pull request directly addresses issue #9594 by changing the undefined $rootdev variable to $diskdev in do_expand_partition, matching the requirement.
Out of Scope Changes check ✅ Passed The pull request contains only the single variable substitution change needed to fix issue #9594, with no extraneous modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review BSP Board Support Packages labels Apr 20, 2026
@iav iav requested a review from hzyitc April 20, 2026 03:45
@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Apr 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release BSP Board Support Packages Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

[Bug]: armbian-resize-filesystem rootdev undefined in do_expand_partition

2 participants