Skip to content

Revert "Disable Sk-am64b as its not compiling on Resolute"#289

Open
jonaswood01 wants to merge 1 commit intoarmbian:mainfrom
jonaswood01:Sk-am64b_revert
Open

Revert "Disable Sk-am64b as its not compiling on Resolute"#289
jonaswood01 wants to merge 1 commit intoarmbian:mainfrom
jonaswood01:Sk-am64b_revert

Conversation

@jonaswood01
Copy link
Copy Markdown

Follow up from #280

This reverts commit 88bb841.

Issue should be fixed when bumping ti-linux-kernel to 6.18 kernel,
see d9761a239dfe088ba4d339851b946aa2ce9646d3 in armbian/build.

I was able to replicate build error with TI SDK tag 11.02.08 (kernel 6.12): https://paste.armbian.com/kasakutuqe
But error not seen anymore using TI SDK tag 12.00.00.07 (kernel 6.18): https://paste.armbian.com/mezezaduhu

@igorpecovnik sk-am64b should be fine to remove from blacklist now

This reverts commit 88bb841.

Issue should be fixed when bumping ti-linux-kernel to 6.18 kernel,
see d9761a239dfe088ba4d339851b946aa2ce9646d3 in armbian/build.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a4376435-5e7b-4be4-b3f9-2ae2be7c1236

📥 Commits

Reviewing files that changed from the base of the PR and between d2e8cca and ca091e0.

📒 Files selected for processing (1)
  • release-targets/targets-release-nightly.blacklist
💤 Files with no reviewable changes (1)
  • release-targets/targets-release-nightly.blacklist

Walkthrough

A single entry, sk-am64b, is removed from the nightly release targets blacklist file. This change removes the exclusion, allowing sk-am64b to be included in the set of targets processed for nightly releases going forward.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: reverting the disable of sk-am64b from the nightly blacklist, which matches the actual changeset.
Description check ✅ Passed The description is clearly related to the changeset, providing context about why sk-am64b is being removed from the blacklist and referencing the specific kernel version fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review labels Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Needs review Seeking for review size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant