Skip to content

[SoundCloud] Use long integers (64-bit) for track IDs to prevent overflows #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TobiGr merged 4 commits into from
Feb 21, 2026
Merged

[SoundCloud] Use long integers (64-bit) for track IDs to prevent overflows #1450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d3eaca
Use 64-bit SoundCloud track IDs
G-flat Jan 28, 2026
fe9c57c
Update mocks to fix failing SoundcloudPlaylistExtractor tests
G-flat Jan 31, 2026
8a4aab4
Add SoundcloudStreamExtractor tests for a small track ID and a track …
G-flat Jan 31, 2026
df10cc1
Record mocks correctly
TobiGr Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions .../schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudPlaylistExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,7 @@ public InfoItemsPage<StreamInfoItem> getInitialPage() {
streamInfoItemsCollector.commit(
new SoundcloudStreamInfoItemExtractor(track));
} else {
// %09d would be enough, but a 0 before the number does not create
// problems, so let's be sure
ids.add(String.format("%010d", track.getInt("id")));
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change causes the mocks to be invalid. Please add a test for a very small ID and also for one that is exceeding the 32 bit of an int. You can fix the tests by recording the mocks for all SoundCloud tests again (see our docs for more info).

Copy link
Copy Markdown
Contributor Author

@G-flat G-flat Jan 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the SoundcloudPlaylistExtractor mocks and also added two SoundcloudStreamExtractor tests, one for a small track ID (135535700) and one for a track ID that's larger than 32 bits of an int (2167944333).

ids.add(String.valueOf(track.getLong("id")));
}
});

Expand Down Expand Up @@ -187,15 +185,15 @@ public InfoItemsPage<StreamInfoItem> getPage(final Page page) throws IOException
final JsonArray tracks = JsonParser.array().from(response);
// Response may not contain tracks in the same order as currentIds.
// The streams are displayed in the order which is used in currentIds on SoundCloud.
final HashMap<Integer, JsonObject> idToTrack = new HashMap<>();
final HashMap<Long, JsonObject> idToTrack = new HashMap<>();
for (final Object track : tracks) {
if (track instanceof JsonObject) {
final JsonObject o = (JsonObject) track;
idToTrack.put(o.getInt("id"), o);
idToTrack.put(o.getLong("id"), o);
}
}
for (final String strId : currentIds) {
final int id = Integer.parseInt(strId);
final long id = Long.parseLong(strId);
try {
collector.commit(new SoundcloudStreamInfoItemExtractor(
Objects.requireNonNull(
Expand Down
2 changes: 1 addition & 1 deletion ...rg/schabi/newpipe/extractor/services/soundcloud/extractors/SoundcloudStreamExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public void onFetchPage(@Nonnull final Downloader downloader) throws IOException
@Nonnull
@Override
public String getId() {
return String.valueOf(track.getInt("id"));
return String.valueOf(track.getLong("id"));
}

@Nonnull
Expand Down
Loading