Remove usage of reflection in timeago-parser module#1288
Remove usage of reflection in timeago-parser module#1288Stypox merged 4 commits intoTeamNewPipe:devfrom
Conversation
|
Thank you! Yes it makes a lot of sense to remove reflection. All of the java files under the |
|
Sure, sounds like no big deal. |
…to generate the Localization files was extracted into its own submodule. The generator now also creates a class that Holds a Map of all Localizations for the timeago-parser.
|
@Stypox I updated the PR to generate the map with the generator. |
|
I guess this means the proguard rule mentioned in the readme can be removed: Line 18 in 0b99100 |
|
removed the line |
Stypox
left a comment
There was a problem hiding this comment.
Thank you! I tested importing the project in Android Studio and running the generator and everything worked without issues. I solved the two comments myself with two commits.
|
Thank you. That was pleasant :) |
We are trying to use the NewPipe extractor library for a native app for the mobile linux OS SailfishOS.
For this we intend to use graal's native-image.
When reflection is used, this needs an entry in a json file for each of the classes that may be used with reflection.
I created the put lines for the hashmap with a simple bashscript.
I think this should be totally equal (in terms of functionallity and maintainability) to the current solution without the drawback (for us) that it uses reflection.