Skip to content

Dependency updates and minSdk bump #13425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stypox merged 4 commits into from
Apr 19, 2026
Merged

Dependency updates and minSdk bump #13425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4effcad
libs: Update checkstyle to latest release and fix violations
theimpulson Apr 16, 2026
2682f23
libs: Update kotlinx.serialization to latest release
theimpulson Apr 16, 2026
7a3d1d9
libs: Bump minSdk to API 23
theimpulson Apr 16, 2026
aa094bc
libs: Bump all libs stuck due to minSdk to latest release
theimpulson Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
strategy:
matrix:
include:
- api-level: 21
- api-level: 23
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the branch protection rules to now require the tests for API 23 and 35. PRs need to be rebased or merged by an administrator.

I saw that we do not require the build to succeed on the refactor branch. Should I change that?

Copy link
Copy Markdown
Member Author

@theimpulson theimpulson Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that we do not require the build to succeed on the refactor branch. Should I change that?

I think that would be good to have.

Copy link
Copy Markdown
Contributor

@TobiGr TobiGr Apr 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

target: default
arch: x86
- api-level: 35
Expand Down
2 changes: 1 addition & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ configure<ApplicationExtension> {
defaultConfig {
applicationId = "org.schabi.newpipe"
resValue("string", "app_name", "NewPipe")
minSdk = 21
minSdk = 23
targetSdk = 35

versionCode = System.getProperty("versionCodeOverride")?.toInt() ?: 1010
Expand Down
29 changes: 5 additions & 24 deletions app/src/main/java/org/schabi/newpipe/fragments/list/kiosk/KioskFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2017-2024 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.fragments.list.kiosk;

import android.os.Bundle;
Expand Down Expand Up @@ -33,30 +38,6 @@

import io.reactivex.rxjava3.core.Single;

/**
* Created by Christian Schabesberger on 23.09.17.
* <p>
* Copyright (C) Christian Schabesberger 2017 <chris.schabesberger@mailbox.org>
* KioskFragment.java is part of NewPipe.
* </p>
* <p>
* NewPipe is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* </p>
* <p>
* NewPipe is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* </p>
* <p>
* You should have received a copy of the GNU General Public License
* along with NewPipe. If not, see <http://www.gnu.org/licenses/>.
* </p>
*/

public class KioskFragment extends BaseListInfoFragment<StreamInfoItem, KioskInfo> {
@State
String kioskId = "";
Expand Down
29 changes: 5 additions & 24 deletions app/src/main/java/org/schabi/newpipe/player/playqueue/PlayQueueAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2016-2026 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.player.playqueue;

import android.content.Context;
Expand All @@ -22,30 +27,6 @@
import io.reactivex.rxjava3.core.Observer;
import io.reactivex.rxjava3.disposables.Disposable;

/**
* Created by Christian Schabesberger on 01.08.16.
* <p>
* Copyright (C) Christian Schabesberger 2016 <chris.schabesberger@mailbox.org>
* InfoListAdapter.java is part of NewPipe.
* </p>
* <p>
* NewPipe is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* </p>
* <p>
* NewPipe is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* </p>
* <p>
* You should have received a copy of the GNU General Public License
* along with NewPipe. If not, see <http://www.gnu.org/licenses/>.
* </p>
*/

public class PlayQueueAdapter extends RecyclerView.Adapter<RecyclerView.ViewHolder> {
private static final String TAG = PlayQueueAdapter.class.toString();

Expand Down
29 changes: 5 additions & 24 deletions app/src/main/java/org/schabi/newpipe/player/playqueue/PlayQueueItemHolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2016-2021 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.player.playqueue;

import android.view.View;
Expand All @@ -8,30 +13,6 @@

import org.schabi.newpipe.R;

/**
* Created by Christian Schabesberger on 01.08.16.
* <p>
* Copyright (C) Christian Schabesberger 2016 <chris.schabesberger@mailbox.org>
* StreamInfoItemHolder.java is part of NewPipe.
* </p>
* <p>
* NewPipe is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* </p>
* <p>
* NewPipe is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* </p>
* <p>
* You should have received a copy of the GNU General Public License
* along with NewPipe. If not, see <http://www.gnu.org/licenses/>.
* </p>
*/

public class PlayQueueItemHolder extends RecyclerView.ViewHolder {
public final TextView itemVideoTitleView;
public final TextView itemDurationView;
Expand Down
26 changes: 5 additions & 21 deletions app/src/main/java/org/schabi/newpipe/settings/SelectChannelFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2017-2025 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.settings;

import android.content.DialogInterface;
Expand Down Expand Up @@ -30,27 +35,6 @@
import io.reactivex.rxjava3.disposables.Disposable;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* Created by Christian Schabesberger on 26.09.17.
* SelectChannelFragment.java is part of NewPipe.
* <p>
* NewPipe is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* </p>
* <p>
* NewPipe is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* </p>
* <p>
* You should have received a copy of the GNU General Public License
* along with NewPipe. If not, see <http://www.gnu.org/licenses/>.
* </p>
*/

public class SelectChannelFragment extends DialogFragment {

private OnSelectedListener onSelectedListener = null;
Expand Down
26 changes: 5 additions & 21 deletions app/src/main/java/org/schabi/newpipe/settings/SelectFeedGroupFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2017-2025 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.settings;

import android.content.DialogInterface;
Expand Down Expand Up @@ -30,27 +35,6 @@
import io.reactivex.rxjava3.disposables.Disposable;
import io.reactivex.rxjava3.schedulers.Schedulers;

/**
* Created by Christian Schabesberger on 26.09.17.
* SelectChannelFragment.java is part of NewPipe.
* <p>
* NewPipe is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* </p>
* <p>
* NewPipe is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* </p>
* <p>
* You should have received a copy of the GNU General Public License
* along with NewPipe. If not, see <http://www.gnu.org/licenses/>.
* </p>
*/

public class SelectFeedGroupFragment extends DialogFragment {

private OnSelectedListener onSelectedListener = null;
Expand Down
26 changes: 5 additions & 21 deletions app/src/main/java/org/schabi/newpipe/settings/SelectKioskFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2017-2022 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.settings;

import android.os.Bundle;
Expand Down Expand Up @@ -25,27 +30,6 @@
import java.util.List;
import java.util.Vector;

/**
* Created by Christian Schabesberger on 09.10.17.
* SelectKioskFragment.java is part of NewPipe.
* <p>
* NewPipe is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* </p>
* <p>
* NewPipe is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* </p>
* <p>
* You should have received a copy of the GNU General Public License
* along with NewPipe. If not, see <http://www.gnu.org/licenses/>.
* </p>
*/

public class SelectKioskFragment extends DialogFragment {
private SelectKioskAdapter selectKioskAdapter = null;

Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/org/schabi/newpipe/util/ListHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public final class ListHelper {
/**
* List of supported YouTube Itag ids.
* The original order is kept.
* @see {@link org.schabi.newpipe.extractor.services.youtube.ItagItem#ITAG_LIST}
* @see org.schabi.newpipe.extractor.services.youtube.ItagItem
*/
private static final List<Integer> SUPPORTED_ITAG_IDS =
List.of(
Expand Down
25 changes: 5 additions & 20 deletions app/src/main/java/org/schabi/newpipe/util/ZipHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
/*
* SPDX-FileCopyrightText: 2018-2026 NewPipe contributors <https://newpipe.net>
* SPDX-License-Identifier: GPL-3.0-or-later
*/

package org.schabi.newpipe.util;

import org.schabi.newpipe.streams.io.SharpInputStream;
Expand All @@ -16,26 +21,6 @@
import java.util.zip.ZipInputStream;
import java.util.zip.ZipOutputStream;

/**
* Created by Christian Schabesberger on 28.01.18.
* Copyright 2018 Christian Schabesberger <chris.schabesberger@mailbox.org>
* ZipHelper.java is part of NewPipe
* <p>
* License: GPL-3.0+
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
* <p>
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
* <p>
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/

public final class ZipHelper {
@FunctionalInterface
public interface InputStreamConsumer {
Expand Down
14 changes: 7 additions & 7 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ autoservice-google = "1.1.1"
autoservice-zacsweers = "1.2.0"
bridge = "v2.0.2"
cardview = "1.0.0"
checkstyle = "13.3.0"
checkstyle = "13.4.0"
coil = "3.4.0"
constraintlayout = "2.2.1"
core = "1.17.0" # Newer versions require minSdk >= 23
core = "1.18.0"
desugar = "2.1.5"
documentfile = "1.1.0"
exoplayer = "2.19.1"
Expand All @@ -26,11 +26,11 @@ junit = "4.13.2"
junit-ext = "1.3.0"
kotlin = "2.3.20"
kotlinx-coroutines-rx3 = "1.10.2"
kotlinx-serialization-json = "1.10.0"
kotlinx-serialization-json = "1.11.0"
ksp = "2.3.6"
ktlint = "1.8.0"
leakcanary = "2.14"
lifecycle = "2.9.4" # Newer versions require minSdk >= 23
lifecycle = "2.10.0"
localbroadcastmanager = "1.1.0"
markwon = "4.6.2"
material = "1.11.0" # TODO: update to newer version after bug is fixed. See https://github.com/TeamNewPipe/NewPipe/pull/13018
Expand All @@ -41,7 +41,7 @@ phoenix = "3.0.0"
preference = "1.2.1"
prettytime = "5.0.8.Final"
recyclerview = "1.4.0"
room = "2.7.2" # Newer versions require minSdk >= 23
room = "2.8.4"
runner = "1.7.0"
rxandroid = "3.0.2"
rxbinding = "4.0.0"
Expand All @@ -62,8 +62,8 @@ teamnewpipe-nanojson = "e9d656ddb49a412a5a0a5d5ef20ca7ef09549996"
# to cause jitpack to regenerate the artifact.
teamnewpipe-newpipe-extractor = "v0.26.1"
viewpager2 = "1.1.0"
webkit = "1.14.0" # Newer versions require minSdk >= 23
work = "2.10.5" # Newer versions require minSdk >= 23
webkit = "1.15.0"
work = "2.11.2"

[libraries]
acra-core = { module = "ch.acra:acra-core", version.ref = "acra" }
Expand Down
Loading