Skip to content

[Refactor] bugfix: make comment section take up full vertical space#13357

Merged
TobiGr merged 1 commit intoTeamNewPipe:refactorfrom
WSU-CptS-481-Spring-2026:bug/refactor/13248-fix-no-comments-scroll
Mar 17, 2026
Merged

[Refactor] bugfix: make comment section take up full vertical space#13357
TobiGr merged 1 commit intoTeamNewPipe:refactorfrom
WSU-CptS-481-Spring-2026:bug/refactor/13248-fix-no-comments-scroll

Conversation

@evanglass
Copy link
Copy Markdown

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

This is a fix for a bug in the refactor branch only

Just a quick one-line fix to restore the touch surface to the whole comments panel even if it doesn't have any comments (including when comments are disabled).

Before/After Screenshots/Screen Record

Before After
Screen_recording_20260316_214628.webm
Screen_recording_20260316_214739.webm

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Mar 17, 2026
@AudricV AudricV added bug Issue is related to a bug GUI Issue is related to the graphical user interface comments Anything to do with comments and comment replies under videos/audios rewrite Issues and PRs related to rewrite labels Mar 17, 2026
@github-project-automation github-project-automation Bot moved this to In Progress in Rewrite Mar 17, 2026
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@TobiGr TobiGr merged commit d0a0b4a into TeamNewPipe:refactor Mar 17, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Rewrite Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios GUI Issue is related to the graphical user interface rewrite Issues and PRs related to rewrite size/small PRs with less than 50 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Refactor] Coments tab isn't scrollable when comment are disabled so you can loose acceess to video

3 participants