Skip to content

[Cancelled] Added a cancel button and current channel name when reloading...#13355

Closed
celestguy wants to merge 1 commit intoTeamNewPipe:refactorfrom
celestguy:feature/cancel-feed-reloading-button
Closed

[Cancelled] Added a cancel button and current channel name when reloading...#13355
celestguy wants to merge 1 commit intoTeamNewPipe:refactorfrom
celestguy:feature/cancel-feed-reloading-button

Conversation

@celestguy
Copy link
Copy Markdown

… feed in FeedFragment

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

It's just a button to cancel feed reloading and showing current updated channel, following the FeedLoadService notification.

Before/After Screenshots/Screen Record

  • Before:
before
  • After:
after

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Mar 16, 2026
@celestguy
Copy link
Copy Markdown
Author

Hope this helps, even if it's not a great feature.

@celestguy celestguy closed this by deleting the head repository Mar 16, 2026
@ghost
Copy link
Copy Markdown

ghost commented Mar 18, 2026

@celestguy As you've said in previous PR it was your first PR, I assume you didn't want to close this PR so just commenting to bring it to your attention

@celestguy
Copy link
Copy Markdown
Author

Hi @dustdfg , thanks for your message !

I’m not sure why I closed it without leaving a comment, but it was intentional. I realize now that I didn’t fully follow the contribution guidelines.

After rethinking it, I’ve come to question whether this feature is as useful as I initially thought when I coded it.

I apologize for any confusion this may have caused. I’d be happy to discuss it further if you think there’s still value in this feature.

@celestguy celestguy changed the title Added a cancel button and current channel name when reloading content… [Canceled] Added a cancel button and current channel name when reloading... Mar 20, 2026
@celestguy celestguy changed the title [Canceled] Added a cancel button and current channel name when reloading... [Cancelled] Added a cancel button and current channel name when reloading... Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium PRs with less than 250 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant