Convert newpipe/util/FilenameUtils.java to kotlin#12944
Conversation
ghost
force-pushed
the
kotlin_refactor3
branch
from
5a9dbd0 to
df69ddb
Compare
theimpulson
requested changes
Dec 28, 2025
| )!! | ||
| val selectedCharset = sharedPreferences.getString( | ||
| context.getString(R.string.settings_file_charset_key), "" | ||
| )!!.ifEmpty { defaultCharset } |
Member
There was a problem hiding this comment.
It should be okay to work with null values here as when will fallback to selectedCharsed in next line.
Author
There was a problem hiding this comment.
- The same thing here. You can't omit second argument
ifEmptyalso catches situation whencontext.getString(R.string.settings_file_charset_key)is empty string not because it is not defined but because it is what was retrieved. That's how it was in original and that is what I preserved. I am not 100% sure that it can happen but if it happens the behavior (at least in this case) should be unchanged
Co-authored-by: Aayush Gupta <aayushgupta219@gmail.com>
ghost
force-pushed
the
kotlin_refactor3
branch
from
df69ddb to
2afebb1
Compare
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
if-elsestatements towhenselectedCharsetAPK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence