Skip to content

Migrate zip import/export to use Path#12415

Merged
Isira-Seneviratne merged 4 commits intoTeamNewPipe:refactorfrom
Isira-Seneviratne:Zip-migrate-Path
Jul 12, 2025
Merged

Migrate zip import/export to use Path#12415
Isira-Seneviratne merged 4 commits intoTeamNewPipe:refactorfrom
Isira-Seneviratne:Zip-migrate-Path

Conversation

@Isira-Seneviratne
Copy link
Copy Markdown
Member

@Isira-Seneviratne Isira-Seneviratne commented Jul 7, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Rewrite the zip import/export code to use Path.
  • Fix an issue with importing/exporting the database that occurred due to the database path being incorrect.

Fixes the following issue(s)

  • Fixes #

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions Bot added the size/medium PRs with less than 250 changed lines label Jul 7, 2025
@ShareASmile ShareASmile added bug Issue is related to a bug code quality Improvements to the codebase to improve the code quality rewrite Issues and PRs related to rewrite labels Jul 7, 2025
@github-project-automation github-project-automation Bot moved this to In Progress in Rewrite Jul 7, 2025
@TobiGr
Copy link
Copy Markdown
Contributor

TobiGr commented Jul 7, 2025

Thank you.

Fix an issue with importing/exporting the database.

Please elaborate

@Isira-Seneviratne
Copy link
Copy Markdown
Member Author

Isira-Seneviratne commented Jul 7, 2025

I found that an error was being thrown when exporting the Room database in the refactor branch due to the database file not being found (this seems to be due to a newer version of Room being used, because it didn't happen in the dev branch).

@Isira-Seneviratne Isira-Seneviratne merged commit 183cc58 into TeamNewPipe:refactor Jul 12, 2025
5 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Rewrite Jul 12, 2025
@Isira-Seneviratne Isira-Seneviratne deleted the Zip-migrate-Path branch July 12, 2025 00:34
@ShareASmile ShareASmile added the import/export Anything related to import/export of data and subscriptions label Jul 12, 2025
@TobiGr TobiGr mentioned this pull request Aug 27, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug code quality Improvements to the codebase to improve the code quality import/export Anything related to import/export of data and subscriptions rewrite Issues and PRs related to rewrite size/medium PRs with less than 250 changed lines

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants