Skip to content

Merge dev to refactor#12348

Merged
Stypox merged 25 commits intoTeamNewPipe:refactorfrom
Isira-Seneviratne:Merge-dev-to-refactor
Jun 11, 2025
Merged

Merge dev to refactor#12348
Stypox merged 25 commits intoTeamNewPipe:refactorfrom
Isira-Seneviratne:Merge-dev-to-refactor

Conversation

@Isira-Seneviratne
Copy link
Copy Markdown
Member

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Merge changes from dev to refactor

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

Profpatsch and others added 25 commits May 7, 2025 14:20
From the discussion in
TeamNewPipe#12188 it reads more
natural for RTL readers.
…ide-of-rtl-usernames

Comments: Put @ on the right side of right-to-left usernames
Fix crashing behaviour with entry in SharedPreferences

A few minor improvements

Added docs for isInBackground

Some more minor changes

Overwrite methods in MainActivity instead of creating a new class
…r-nightly-badges

Add dev and refactor nightly build badges
Copied select_channel_fragment to select_feed_group_fragment

Copied select_channel_item to select_feed_group_item

# Change
Replaced the Layout references in the new Class SelectFeedGroupFragment
Adjusted the new Class SelectFeedGroupFragment for its Role
- Renamed Variables
- adjusted Imports
- adjusted Interface with FeedGroupEntity Values
Adjusted select_feed_group_fragment Layout
 - reference select_feed_group_item layout
 - use new Strings

Added strings:
- select_a_feed_group
- no_feed_group_created_yet
Added FEEDGROUP Tab Code to
 - ChooseTabsFragment
 - Tab

Added strings:
- feed_group_page_summary
Layout select_feed_group_item (FeedGroup Picker in the Settings)
Remove rounded style from the icons
- use default fragment_feed_title for TabName
- only clear FeedFragment bar subtitle when it matches the groupName to clear.
The Tabname displays the default Feed title.
# Conflicts:
#	app/src/main/java/org/schabi/newpipe/MainActivity.java
@github-actions github-actions Bot added the size/large PRs with less than 750 changed lines label Jun 11, 2025
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Stypox Stypox merged commit d81b571 into TeamNewPipe:refactor Jun 11, 2025
7 of 8 checks passed
@Stypox
Copy link
Copy Markdown
Member

Stypox commented Jun 11, 2025

Thanks!

@ShareASmile ShareASmile added meta Related to the project but not strictly to code rewrite Issues and PRs related to rewrite labels Jun 12, 2025
@Isira-Seneviratne Isira-Seneviratne deleted the Merge-dev-to-refactor branch June 14, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the project but not strictly to code rewrite Issues and PRs related to rewrite size/large PRs with less than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants