Add PlayQueueItem equals and hashCode#12347
Merged
Isira-Seneviratne merged 5 commits intoTeamNewPipe:refactorfrom Jul 9, 2025
Merged
Add PlayQueueItem equals and hashCode#12347Isira-Seneviratne merged 5 commits intoTeamNewPipe:refactorfrom
Isira-Seneviratne merged 5 commits intoTeamNewPipe:refactorfrom
Conversation
Isira-Seneviratne
force-pushed
the
PlayQueueItem-equals
branch
2 times, most recently
from
741788a to
4dbc7a5
Compare
|
ShareASmile
added
the
code quality
Contributor
HatakeKakashri
left a comment
HatakeKakashri
left a comment
There was a problem hiding this comment.
Thanks for this. I would prefer the Queue classes to be converted to Kotlin in the same PR. WDYT
| if (playQueue == null) { | ||
| playQueue = new SinglePlayQueue(result); | ||
| } | ||
| if (stack.isEmpty() || !stack.peek().getPlayQueue() |
Contributor
There was a problem hiding this comment.
Should be possible to use == operator here now.
Member
Author
There was a problem hiding this comment.
That's only possible for Kotlin.
github-actions
Bot
added
size/giant
ShareASmile
added
the
ready for review
Isira-Seneviratne
force-pushed
the
PlayQueueItem-equals
branch
from
bd28d7d to
31f8dd0
Compare
ShareASmile
added
rewrite
TobiGr
added a commit
to TobiGr/NewPipe
that referenced
this pull request
Feb 6, 2026
This was removed in TeamNewPipe#12347 / 31f8dd0
TobiGr
reviewed
Feb 6, 2026
| && newQueue.size() == 1 && newQueue.getItem() != null | ||
| && playQueue != null && playQueue.size() == 1 && playQueue.getItem() != null | ||
| && newQueue.getItem().getUrl().equals(playQueue.getItem().getUrl()) | ||
| && newQueue.getItem().getRecoveryPosition() != PlayQueueItem.RECOVERY_UNSET) { |
Contributor
There was a problem hiding this comment.
I just ran into issues with this. Please ensure to keep constants while converting to kotlin in the futur. I reverted the removal of the RECOVERY_UNSET constant in #13202
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Feb 7, 2026
This was removed in TeamNewPipe#12347 / 31f8dd0
whistlingwoods
pushed a commit
to whistlingwoods/FoxPipe
that referenced
this pull request
Feb 7, 2026
This was removed in TeamNewPipe#12347 / 31f8dd0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence