Fix equality comparison in Tab class#12322
Merged
AudricV merged 1 commit intoTeamNewPipe:devfrom May 31, 2025
Merged
Conversation
ShareASmile
added
channel
|
AudricV
added
bug
AudricV
approved these changes
May 31, 2025
Member
AudricV
left a comment
AudricV
left a comment
There was a problem hiding this comment.
Thank you! Try to use a better branch name for your future PRs :)
AudricV
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
The comparison would always return as not equal, despite in fact being equal prior to this change
Before/After Screenshots/Screen Record
This change does not visually affect the UI in anyway.
Fixes the following issue(s)
I did not create an Issue for this minor error I spotted while working on a modified feature version
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence