Skip to content

Fix image minimizer pattern#12215

Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom
naveensingh:fix-image-minimizer
Apr 28, 2025
Merged

Fix image minimizer pattern#12215
Stypox merged 1 commit intoTeamNewPipe:devfrom
naveensingh:fix-image-minimizer

Conversation

@naveensingh
Copy link
Copy Markdown
Contributor

@naveensingh naveensingh commented Apr 27, 2025

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Added non-capturing group that matches either of these paths:
    • user-attachments/assets (new image url path)
    • owner/repo/assets/digits (kept for old/stale issues with big images)
  • Fixed typo in variable name

I was just wandering here and realized the images were not being minimized (e.g. #12142). If that is intentional, feel free to close this.

Fixes the following issue(s)

  • Not tracked. Let me know if it's required.

Due diligence

Added non-capturing group that matches either:

 - `user-attachments/assets`
 - `owner/repo/assets/digits`
@github-actions github-actions Bot added the size/small PRs with less than 50 changed lines label Apr 27, 2025
@Stypox
Copy link
Copy Markdown
Member

Stypox commented Apr 28, 2025

Thank you!

@Stypox Stypox merged commit aa1b7f8 into TeamNewPipe:dev Apr 28, 2025
1 check passed
@ShareASmile ShareASmile added the meta Related to the project but not strictly to code label Apr 28, 2025
@naveensingh naveensingh deleted the fix-image-minimizer branch May 14, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Related to the project but not strictly to code size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants