Fix loading StreamInfo twice on first VideoDetailFragment opening

[Stypox]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

While working on #11955 I realized that when VideoDetailFragment is first started, the video loading is initiated both by VideoDetailFragment and by the NavigationHelper.openVideoDetailFragment() function, leading to the stream info loading twice in the background. From the second time openVideoDetailFragment() is invoked, the VideoDetailFragment is already running in the background, and so its initial logic does not run.

To solve this bug I made it so that NavigationHelper.openVideoDetailFragment() first opens the VideoDetailFragment as if it were in collapsed bottom sheet state (i.e. with url = null, see how VideoDetailFragment.wasCleared() is called in VideoDetailFragment.doInitialLoadLogic(). I am not sure if this is just a hack or is the actual intended behavior, but fortunately we're going to ditch all of this code soon. I think this is quite safe to merge anyway, since the change happens in NavigationHelper.openVideoDetailFragment() which is clearly defined.

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

• I read the contribution guidelines.

[AudricV]

Let's try this and see if users report things :P

If you want nitpicks, then change in the comment videoUrl to url and video to stream, as we can play audio-only streams :)

[Stypox]

Fixed in 01bf855, thanks for noticing ;-)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud