[Cancelled] Added a cancel button and current channel name when reloading...#13355
Closed
celestguy wants to merge 1 commit intoTeamNewPipe:refactorfrom
Closed
[Cancelled] Added a cancel button and current channel name when reloading...#13355celestguy wants to merge 1 commit intoTeamNewPipe:refactorfrom
celestguy wants to merge 1 commit intoTeamNewPipe:refactorfrom
Conversation
… feed in FeedFragment
Author
|
Hope this helps, even if it's not a great feature. |
|
@celestguy As you've said in previous PR it was your first PR, I assume you didn't want to close this PR so just commenting to bring it to your attention |
Author
|
Hi @dustdfg , thanks for your message ! I’m not sure why I closed it without leaving a comment, but it was intentional. I realize now that I didn’t fully follow the contribution guidelines. After rethinking it, I’ve come to question whether this feature is as useful as I initially thought when I coded it. I apologize for any confusion this may have caused. I’d be happy to discuss it further if you think there’s still value in this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… feed in FeedFragment
What is it?
refactorbranchDescription of the changes in your PR
It's just a button to cancel feed reloading and showing current updated channel, following the FeedLoadService notification.
Before/After Screenshots/Screen Record
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence